Add-on Store: First press of Ctrl+Tab shouldn't be improperly announced

[XLTechie]

Steps to reproduce:

• Open the Add-on store.
• Press Ctrl+Tab.

Actual behavior:

NVDA speaks:

tab control
panel

Expected behavior:

NVDA should speak:

Updatable add-ons  tab  selected

Since that's the tab that has been changed to.

Additional note:

Subsequent presses of Ctrl+Tab do speak the selected tab, but the first one is never spoken.

System configuration

NVDA portable, version alpha-28372,94715243
Microsoft® Windows® Operating System version 10.0.19041.2311

[seanbudd]

This could potentially be fixed by always manually focusing the selected tab's control when performing ctrl+tab, but this would make #14987 invalid

[XLTechie]

IMO, it's the result that matters. My first solution in #14987 is a better end result than solving this would be. I.e. If it says the correct tab name, but still focuses some sort of interstitial panel that has no meaning to the user, the UX problem is not solved. I would personally prefer, if a single solution is sought, that we solve #14987 instead. Any solution to that will probably solve this as a byproduct.

[CyrilleB79]

For reference in Windows Explorer files properties dialog, we have:

• if an item in the tab page is focused (e.g. Hidden checkbox, or Read-only checkbox), control+tabbing put the focus in the new tab page
• if the tab header (e.g. General, Shared) is focused, control+tabbing put the focus on the next tab header and not in the tab page.

IMO, this behaviour is a good UX and should be copied in the add-on store.

[CyrilleB79]

@seanbudd would this PR deserve being integrated in NVDA 2023.2? For now it is not included in its milestone.

Of course it's not a critical bug at all.

However, I imagine that ctrl+tab may be the preferred way to change tab in the store. Leaving this bug in NVDA 2023.2 make the discovery of the store less easy for general users and would also lead to a bad first impression.

[XLTechie]

I agree with what @CyrilleB79 describes in #14986 (comment). This is the desirable behavior.
(Although I believe ctrl+tab is meant in the comment, where alt+tab is used)

[CyrilleB79]

I agree with what @CyrilleB79 describes in #14986 (comment). This is the desirable behavior. (Although I believe ctrl+tab is meant in the comment, where alt+tab is used)

Thanks. I have updated my previous comment for clarity.

[seanbudd]

This is a minor bug with no clear solution or easy fix - I don't think it should hold up the release

[ABuffEr]

Hi,
it's not resolved yet. And it'll continue to give a bad impression in incoming 2024.1.
Personally I agree with Cyrille's observations, but add also that Windows Explorer not keeps focus moving among tabs. So I suppose that we'd like to get focus on add-on list, as when opening the store.
This result, though, seems not so trivial to get working, because adding self.addonListView.SetFocus() to page changed handler NVDA reads the list names inconsistently, and nothing else of the updated panel.
By contrast, adding self.addonListTabs.SetFocus() seems to work well, always focusing on tab title (instead of say "tab control panel").
Moreover, due to filters presence before the add-on list, and the fact those always resets their status, I'm not totally convinced that focusing on add-on list when opening the store is the best choice, but it's irrelevant at this stage.

[Adriani90]

The filter reset issue is not ideal at all, I filled #15947 for that.

In my view it would be an improvement to redirect the focus automatically to the tab area when pressing ctrl+tab if this is the only way of solving this particular issue.

[XLTechie]

I agree with @Adriani90. Any solution is better than now.

[Adriani90]

Closing as fixed in #15988.