Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unchecking "Report Comments" and "Report Titles" in the document formatting panel will cause ms word to crash and quit. #15019

Closed
cary-rowen opened this issue Jun 18, 2023 · 3 comments · Fixed by #15307
Labels
app/microsoft-office app-specific bug/app-crash p2 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation.
Milestone

Comments

@cary-rowen
Copy link
Contributor

cary-rowen commented Jun 18, 2023

Steps to reproduce:

  1. NVDA+ Ctrl +D to open the document format setting panel, uncheck "ReportComments" and "ReportHeadings", and then save the settings.
  2. In the "Use UI Automation to access Microsoft Word document controls" in the advanced settings panel, select "" "Default".
  3. Press Win+R and enter 'winword' to open MS Word and create a new "blank document".

Actual behavior:

MSWord crashes and quits, NVDA recovers from freeze.
P.S. This is only reproducible when Word uses object model, not UIA.

Expected behavior:

MSWord and NVDA both work fine.

NVDA logs, crash dumps and other attachments:

NVDA-log.txt

System configuration

NVDA installed/portable/running from source:

Installed

NVDA version:

2023.1, alpha-28430,3920fa58

Windows version:

Windows 10 22H2 (AMD64) build 19045.3086

Name and version of other software in use when reproducing the issue:

MSO (Version 2305 Build 16.0.16501.20074)

Other information about your system:

None

Other questions

Does the issue still occur after restarting your computer?

Yes

Have you tried any other versions of NVDA? If so, please report their behaviors.

No

If NVDA add-ons are disabled, is your problem still occurring?

Yes

Does the issue still occur after you run the COM Registration Fixing Tool in NVDA's tools menu?

Yes

@CyrilleB79
Copy link
Collaborator

Uh! Confirmed and 100% reproducible on my side with 2 different versions of Word 2016!

@enessaribas
Copy link

not reproduceable for me on word version 2305 Build 16.0.16501.20074)
NVDA alpha-28406,bcc7f254

@CyrilleB79
Copy link
Collaborator

Probably this is only reproducible when Word uses object model, not UIA.

@enessaribas if you have Word with UIA set on "Always", or on "Where suitable" with Windows 11, try to set it on "Only where necessary" and you will probably be able to reproduce the crash.

@seanbudd seanbudd added bug/app-crash app/microsoft-office app-specific p2 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation. labels Jun 20, 2023
@seanbudd seanbudd added this to the 2023.2 milestone Jun 20, 2023
@seanbudd seanbudd modified the milestones: 2023.2, 2023.3 Aug 18, 2023
seanbudd added a commit that referenced this issue Aug 21, 2023
Fixes #15019

Summary of the issue:
NVDA only fetches object text range information if "report headings" and "report comments and notes" are enabled.
This only happens when using the object model.
This causes a crash when attempting to update the caret, as we try to fetch range information that hasn't been generated by nvdaHelper.

Description of user facing changes
Fix crash in Microsoft Word when Document formatting options "report headings" and "report comments and notes" were not enabled.

Description of development approach
Always fetch range information, regardless of these options.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app/microsoft-office app-specific bug/app-crash p2 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants