Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Map flattened object nav gestures by default #15053

Closed
LeonarddeR opened this issue Jun 23, 2023 · 6 comments · Fixed by #15065
Closed

Map flattened object nav gestures by default #15053

LeonarddeR opened this issue Jun 23, 2023 · 6 comments · Fixed by #15065
Labels
p4 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation.
Milestone
2023.2

Comments

@LeonarddeR
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

Object navigation can be difficult to grasp for some people. It might be helpful to assign the flattened object nav gestures (that are now only available on touch screen)by default.

Describe the solution you'd like

Add the following additional gesture mappings:

  • navigatorObject_nextInFlow: ("kb(desktop):NVDA+numpad9", "kb(laptop):shift+NVDA+=")
    • navigatorObject_previousInFlow: ("kb(desktop):NVDA+numpad3", "kb(laptop):shift+NVDA+-")

Describe alternatives you've considered

Leave as is
@bramd
Copy link
Contributor

bramd commented Jun 23, 2023

I like the power of a nested object nav if the structure of an app is correct, but I tried explaining how to navigate with NVDA's review cursor to multiple users and most of them have difficulty understanding why and when they need to use up/down/left/right. Same users have no issue understanding swipe gestues in mobile VoiceOver or using Narrator with capslock+arrows. So yes, I think mapping this by default is a great idea.

@LeonarddeR
Copy link
Collaborator Author

What do you think about the proposed gestures?

@burmancomp
Copy link
Contributor

I suppose laptop layout gestures like "kb(laptop):NVDA+;", "kb(laptop):NVDA+'", "kb(laptop):NVDA+" are not available?

@seanbudd
Copy link
Member

I think the suggested gestures for desktop make more sense swapped

@seanbudd seanbudd added p4 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation. labels Jun 28, 2023
@LeonarddeR
Copy link
Collaborator Author

I suppose laptop layout gestures like "kb(laptop):NVDA+;", "kb(laptop):NVDA+'", "kb(laptop):NVDA+" are not available?

Actually, they are. However for laptop, I prefer at least the shift+NVDA combination to stay consistent with the other keys.

I think the suggested gestures for desktop make more sense swapped

You are right. I based them on the next/previous review mode gestures, but I think those are actually a bit weird.

@burmancomp
Copy link
Contributor

I suppose laptop layout gestures like "kb(laptop):NVDA+;", "kb(laptop):NVDA+'", "kb(laptop):NVDA+" are not available?

Actually, they are. However for laptop, I prefer at least the shift+NVDA combination to stay consistent with the other keys.

I have not strong opinion about gestures. You surely consider to keep gestures consistent, as well as to keep them as easy to use as possible.

@LeonarddeR LeonarddeR mentioned this issue Jun 28, 2023
Merged
6 tasks
seanbudd pushed a commit that referenced this issue Jul 4, 2023
@LeonarddeR
Add default keyboard mappings for flattened object nav scripts (#15065)
5c4e6e1 
Link to issue number:
Fixes #15053

Summary of the issue:
Object navigation can be difficult to grasp for some people. It is helpful to assign the flattened object nav gestures (that are now only available on touch screen)by default.

Description of user facing changes
See change log items

Description of development approach
Added gestures to scripts in globalCommands.
@nvaccessAuto nvaccessAuto added this to the 2023.2 milestone Jul 4, 2023
@CyrilleB79 CyrilleB79 mentioned this issue Oct 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p4 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation.
Projects
None yet
Milestone
2023.2
Development

Successfully merging a pull request may close this issue.

Add default keyboard mappings for flattened object nav scripts LeonarddeR/nvda
5 participants
@bramd @LeonarddeR @seanbudd @nvaccessAuto @burmancomp