Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to write some characters with Braille Sense in french #15306

Closed
jf-fr-git opened this issue Aug 17, 2023 · 5 comments · Fixed by #16118
Closed

Unable to write some characters with Braille Sense in french #15306

jf-fr-git opened this issue Aug 17, 2023 · 5 comments · Fixed by #16118
Labels
p3 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation.
Milestone

Comments

@jf-fr-git
Copy link

Is your feature request related to a problem? Please describe.

With a Hims BrailleSense 6, in terminal mode, four braille combinations cannot be performed on the braille keyboard.
The corresponding combinations are occupied by the following NVDA commands:

  • dots 2-7: alt left arrow
  • dots 5-7: alt right arrow
  • dots 2-3-7: alt up arrow
  • dots 5-6-7: alt down arrow

Describe the solution you'd like

I would like to be able to type these four braille combinations with the braille keyboard, because they correspond to the following characters in the French (unified) computer braille table 8 dots:

  • dots 2-7: Å (LATIN CAPITAL LETTER A WITH RING ABOVE, decimal 197)
  • dots 5-7: ‹ (SINGLE LEFT-POINTING ANGLE QUOTATION MARK, decimal 8249)
  • dots 2-3-7: £ (POUND SIGN, decimal 163)
  • dots 5-6-7: > (GREATER-THAN SIGN : decimal 62)

Describe alternatives you've considered

Additional context

@CyrilleB79
Copy link
Collaborator

@LeonarddeR any idea why these braille chords are taken by NVDA shortcuts?

PS: @jf-fr-git congratulation for opening your first ticket!

@seanbudd seanbudd added p3 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation. labels Aug 22, 2023
@LeonarddeR
Copy link
Collaborator

I don't know why these are bound, but I agree they should be removed.

@CyrilleB79
Copy link
Collaborator

@LeonarddeR you seem to be the author of the commit which introduced the hims driver, probably on behalf of @BabbageCom.

Who were your contact? Or may someone else at @BabbageCom answer? Maybe @FalkoBabbage?

It's surely a good idea to remove such gestures. But the manufacturer would probably prefer to bind these shortcuts to another chord gesture. This would not make sense to have no predefined gesture for alt+arrows but predefined gestures for alt+shift+arrows.

@jf-fr-git or any user of Braille Sense, you may also suggest logical 4 alternative gestures for alt+arrws if you have an idea.

@CyrilleB79
Copy link
Collaborator

@EdKweon I can see that you are currently active on HIMS code (see #16033).

I would like to take this opportunity to ask you to progress the current issue.

I sent an e-mail to Hims Support on October 5, 2023 to notify them of this issue and I got an immediate answer from Chris: "I will pass this on to our developers."
However, unless I have missed another message, I have had no news from HIMS people since then, even after I sent another e-mail on November 20, 2023.

As a reminder the issue is the following:
The 4 shortcuts defined to emulate alt+arrow are defined only with dot keys; on the contrary, other shortcuts associate dot keys with space key or f1 to f8 key. Thus, these 4 shortcuts conflict with braille entries in the braille table. In French, these entries are the 4 following characters: Å, , £ and >. Two of them are quite common.
Thus these shortcuts should either be deleted or redefined so that they do not conflict with a braille character input.

Could you provide a fix for this issue? Or at least give some indications so that anyone else wanting to fix it can?

What would you like to do regarding these 4 shortcuts corresponding to entries in the braille table?

  • Would you like just to have them removed?
  • Or would you associate new shortcuts to them? In this case, take care to use at least one non-dot key in the gesture.

As a reminder, all the shortcuts defined in the HIMS driver are also listed in the
HIMS devices paragraph of NVDA's documentation.

@KihunJang1981
Copy link

BrailleSense 6 has alt and control key on both sides of space.
I think that develop assigne alt-dot-5 key. And this key send the dots-5-7 key.
I will change alt-dot-5 key in the BrailleSense 6.
And EdKweon will change NVDA map for math alt-left arrow key.
Thank you.

seanbudd pushed a commit that referenced this issue Feb 2, 2024
…ce (#16118)

Fixes #15306

Summary of the issue:
With a Hims BrailleSense 6, in terminal mode, four braille combinations cannot be performed on the braille keyboard.

Description of user facing changes
Some characters in french can type alt+arrow combination keys in braillesense.

Description of development approach
alt+arrow combination keys in hims driver which were assigned to Braillesense device was changed.
@nvaccessAuto nvaccessAuto added this to the 2024.2 milestone Feb 2, 2024
Nael-Sayegh pushed a commit to Nael-Sayegh/nvda that referenced this issue Feb 15, 2024
…ce (nvaccess#16118)

Fixes nvaccess#15306

Summary of the issue:
With a Hims BrailleSense 6, in terminal mode, four braille combinations cannot be performed on the braille keyboard.

Description of user facing changes
Some characters in french can type alt+arrow combination keys in braillesense.

Description of development approach
alt+arrow combination keys in hims driver which were assigned to Braillesense device was changed.
SaschaCowley pushed a commit to SaschaCowley/nvda that referenced this issue Feb 27, 2024
…ce (nvaccess#16118)

Fixes nvaccess#15306

Summary of the issue:
With a Hims BrailleSense 6, in terminal mode, four braille combinations cannot be performed on the braille keyboard.

Description of user facing changes
Some characters in french can type alt+arrow combination keys in braillesense.

Description of development approach
alt+arrow combination keys in hims driver which were assigned to Braillesense device was changed.
Adriani90 pushed a commit to Adriani90/nvda that referenced this issue Mar 13, 2024
…ce (nvaccess#16118)

Fixes nvaccess#15306

Summary of the issue:
With a Hims BrailleSense 6, in terminal mode, four braille combinations cannot be performed on the braille keyboard.

Description of user facing changes
Some characters in french can type alt+arrow combination keys in braillesense.

Description of development approach
alt+arrow combination keys in hims driver which were assigned to Braillesense device was changed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants