NVDA menu: add explicit shortcut keys and avoid collisions

[CyrilleB79]

Link to issue number:

Closes #15362

Summary of the issue:

"Add-on store" item has been added with "S" as a shortcut key in NVDA tools menu in NVDA 2023.2.
Unfortunately "S" was already used for "Speech viewer" (as its first letter), even if it was not defined explicitly. Now that there is an explicit mapping for "Add-on store", implicit shortcut key definition for "Speech viewer" becomes masked and does not work anymore.

In case the add-ons add new items in the menus with explicit definition of shortcut keys, other menu item that only use implicit definition of the shortcut key may be masked as well.

Description of user facing changes

Explicitly define shortcut keys in main NVDA menu and avoid collisions (i.e. two times the same letter in the same menu).

Description of development approach

In main NVDA menu:

• "Tools: add explicitly "T"
• "Reset configuration to factory defaults")": Change "R" to "F" because was already used by "Revert to saved configuration"
• "Donate": add explicitly "D"

In "Tools" submenu:

• "Reload plugins e": change "R" to "E" since "R" already taken by "Run COM Registration Fixing tool..."
• "Add-on store": "A" instead of "S", as discussed in Speech viewer no longer has a shortcut key in the tools menu in 2023.2 #15362 (comment), to avoid collision with "Speech viewer"
• "View log": "L" instead of "V" to be more intuitive, as discussed in NVDA menu: add explicit shortcut keys and avoid collisions #15364 (comment)
• For all other items, explicitly mark the accelerator

Help menu:

• "About": Explicitly set "A"
• All other items are already explicitly marked.

Testing strategy:

• Visually check that all items are explicitly defined, i.e. that the shortcut key is underlined; an implicit definition targetting the first letter would not show an underlined character instead.
• Try to activate all the items that have been changed with their shortcut key

Known issues with pull request:

There may still be shortcut collisions or masked implicit definitions in this menu for items added by add-ons. It's up to add-on author to adapt if needed.

Change log entries:

Not needed

Code Review Checklist:

• Pull Request description:
  • description is up to date
  • change log entries
• Testing:
  • Unit tests
  • System (end to end) tests
  • Manual testing
• API is compatible with existing add-ons.
• Documentation:
  • User Documentation
  • Developer / Technical Documentation
  • Context sensitive help for GUI changes
• UX of all users considered:
  • Speech
  • Braille
  • Low Vision
  • Different web browsers
  • Localization in other languages / culture than English
• Security precautions taken.

[AppVeyorBot]

• PASS: Translation comments check.
• PASS: Unit tests.
• FAIL: Lint check. See test results for more information.
• PASS: System tests (tags: installer NVDA).
• Build (for testing PR): https://ci.appveyor.com/api/buildjobs/kli8tcdq5tr7brch/artifacts/output/nvda_snapshot_pr15364-29059,f4c63523.exe
• CI timing (mins):
  INIT 0.0,
  INSTALL_START 0.8,
  INSTALL_END 0.8,
  BUILD_START 0.0,
  BUILD_END 23.5,
  TESTSETUP_START 0.0,
  TESTSETUP_END 0.3,
  TEST_START 0.0,
  TEST_END 22.2,
  FINISH_END 0.1

See test results for failed build of commit f4c63523a5

[seanbudd]

Thanks for fixing this up @CyrilleB79

[seanbudd]

Thanks @CyrilleB79

[CyrilleB79]

I have addressed all review comments in 98e6ba1. We end up with:

• View log l
• Speech viewer s
• Braille viewer b
• Add-on store... a
• Python console p
• Create portable copy... c
• Install NVDA... i
• Reload plugins e

View log, Add-on store and Reload plugins have their shortcut modified with respect to 2023.2. It should not cause any issue with previously given instructions since Add-on store is recent and other ones have associated NVDA gestures (NVDA+F1 and NVDA+control+F3).

[AppVeyorBot]

• PASS: Translation comments check.
• PASS: Unit tests.
• PASS: Lint check.
• FAIL: System tests (tags: installer NVDA). See test results for more information.
• Build (for testing PR): https://ci.appveyor.com/api/buildjobs/rbb4rj1nuhhbb1pc/artifacts/output/nvda_snapshot_pr15364-29092,199f984b.exe
• CI timing (mins):
  INIT 0.0,
  INSTALL_START 0.9,
  INSTALL_END 0.9,
  BUILD_START 0.0,
  BUILD_END 25.6,
  TESTSETUP_START 0.0,
  TESTSETUP_END 0.3,
  TEST_START 0.0,
  TEST_END 22.4,
  FINISH_END 0.1

See test results for failed build of commit 199f984bd7

[tmthywynn8]

Is it possible to change "Run COM Registration Fixing tool..." to "T" and "Reload plugins" to "R"? Two reasons:

1. "T' could be the mnemonic for "tool" and "R" for "reload". This makes way more sense than "E" not being a mnemonic for anything.
2. Users of the Remote add-on have been used to the "E" mnemonic for years, and while this is not part of NVDA core, making change for change's sake is not that great of a reason (see this post for a few disgruntled users).

[seanbudd]

Please open a new issue (feature request) thanks