Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report cell coordinates when navigating with mouse in Excel #15420

Closed
Qchristensen opened this issue Sep 11, 2023 · 6 comments · Fixed by #15518
Closed

Report cell coordinates when navigating with mouse in Excel #15420

Qchristensen opened this issue Sep 11, 2023 · 6 comments · Fixed by #15518
Assignees
Labels
app/microsoft-office feature/mouse-tracking p3 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation.
Milestone

Comments

@Qchristensen
Copy link
Member

Is your feature request related to a problem? Please describe.

(Requested by a user via email)

When hovering the mouse over cells in Excel, NVDA reports the contents of a given cell, but not the coordinates.

Describe the solution you'd like

An option to report cell coordinates when hovering with the mouse.

Describe alternatives you've considered

Additional context

Magnification users particularly may not have the top or left edge of the spreadsheet (where the visual cell rows and columns) visible when navigating. And if they do, reading them requires scanning across and up from the current location and back which can be difficult for low vision users.

@seanbudd seanbudd added feature/mouse-tracking p3 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation. app/microsoft-office labels Sep 11, 2023
@LeonarddeR
Copy link
Collaborator

Does NVDA report the table cell roles when you enable the mouse option Report role when mouse enters object?

@hwf1324
Copy link
Contributor

hwf1324 commented Sep 14, 2023

Does NVDA report the table cell roles when you enable the mouse option Report role when mouse enters object?

Yes, the cell role is reported once for each cell moved to.
But it only says "cell", not coordinates.

@LeonarddeR
Copy link
Collaborator

In that case, I think we should consider changing the Report role when mouse enters object option to something like Report object when mouse enters it, and let this option report the object as it was gaining focus.

@hwf1324
Copy link
Contributor

hwf1324 commented Sep 14, 2023

In that case, I think we should consider changing the Report role when mouse enters object option to something like Report object when mouse enters it, and let this option report the object as it was gaining focus.

That's a nice idea, maybe it can also solve #15397 at the same time.

@LeonarddeR LeonarddeR added the blocked/needs-product-decision A product decision needs to be made. Decisions about NVDA UX or supported use-cases. label Sep 14, 2023
@LeonarddeR
Copy link
Collaborator

I marked this as "needs product decision". In short, I propose:

  1. Rename Report role when mouse enters object to Report object when mouse enters it
  2. Report similar properties as for OutputReason.FOCUSENTERED, except for description.

@seanbudd
Copy link
Member

Given there's been no negative feedback I think your proposal is sufficient @LeonarddeR

@seanbudd seanbudd removed the blocked/needs-product-decision A product decision needs to be made. Decisions about NVDA UX or supported use-cases. label Sep 25, 2023
@LeonarddeR LeonarddeR self-assigned this Sep 25, 2023
@nvaccessAuto nvaccessAuto added this to the 2024.1 milestone Sep 28, 2023
seanbudd pushed a commit that referenced this issue Sep 28, 2023
Fixes #15420

Summary of the issue:
When the mouse option "Report role when mouse enters object" is enabled, NVDA reports the role of objects when the mouse enters them. However, the role is in pretty insufficient in many situations, for example:

Check boxes: checked state is missing
Table cells: coordinates are missing
Description of user facing changes
Renamed "Report role when mouse enters object" to "Report object when mouse enters it"
When enabled, additional properties (such as states, cell coordinates, table info) will be reported

Description of development approach
Implemented some additional logic to speak objects with reason controlTypes.OutputReason.MOUSE, and made event_mouseMove use speech.speakObject.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app/microsoft-office feature/mouse-tracking p3 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants