Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

After a second installation of an incompatible add-on, this one is disabled after restarting NVDA. #15584

Closed
paulber19 opened this issue Oct 5, 2023 · 6 comments · Fixed by #15765
Closed

After a second installation of an incompatible add-on, this one is disabled after restarting NVDA. #15584

paulber19 opened this issue Oct 5, 2023 · 6 comments · Fixed by #15765
Labels
feature/addon-store Features / behavior of the add-on Store p4 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation.
Milestone
2024.1

Comments

@paulber19
Copy link

paulber19 commented Oct 5, 2023 •
edited by seanbudd

Steps to reproduce:

install an incompatible add-on for the first time from its installation file.

  • restart NVDA.
  • check that the add-on is activated.
  • install this add-on again without uninstalling it.
  • restart NVDA.

The add-on is then deactivated.

Actual behavior:

Expected behavior:

The add-on should be activated as when it was first installed.

NVDA logs, crash dumps and other attachments:

System configuration

NVDA installed/portable/running from source:

NVDA portable

NVDA version:

2023.3Beta4 and alpha

Windows version:

Windows 10 22H2 (10.0.19045) workstation x86

Name and version of other software in use when reproducing the issue:

Other information about your system:

Other questions

Does the issue still occur after restarting your computer?

Yes

Have you tried any other versions of NVDA? If so, please report their behaviors.

If NVDA add-ons are disabled, is your problem still occurring?

Does the issue still occur after you run the COM Registration Fixing Tool in NVDA's tools menu?

Yes
@lukaszgo1
Copy link
Contributor

Could you please fully fill the issue template?

@paulber19
Copy link
Author

paulber19 commented Oct 5, 2023 via email

@lukaszgo1
Copy link
Contributor

There is still a lot of important info (which was asked in the template) missing:

  • With what add-on you have tested exactly
  • Has this worked in NVDA 2023.2

@paulber19
Copy link
Author

paulber19 commented Oct 5, 2023 via email

@paulber19
Copy link
Author

paulber19 commented Oct 5, 2023 via email

@CyrilleB79
Copy link
Collaborator

Confirmed on my side on NVDA 2023.3beta4.

@seanbudd seanbudd added p4 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation. feature/addon-store Features / behavior of the add-on Store labels Oct 6, 2023
@seanbudd seanbudd added this to the 2024.1 milestone Oct 6, 2023
@lukaszgo1 lukaszgo1 mentioned this issue Nov 9, 2023
Merged
5 tasks
seanbudd pushed a commit that referenced this issue Nov 27, 2023
@lukaszgo1
When re-installing incompatible add-ons preserve compatibility overri…
2423b12 
…de (#15765)

Fixes #15584

Summary of the issue:
When reinstalling incompatible add-on the fact that user manually overridden its compatibility was lost i.e. add-on was disabled after restart. This occurred because even though name of the add-on was added to the set of add-ons for which compatibility should be overridden, it was removed from the set after restart when uninstalling previous version of the add-on. Note that removal during uninstall is pretty much intentional i.e. when reinstalling add-on with the same name it should not be automatically marked as overridden compatibility, even if its previous version was.

Description of user facing changes
Reinstalled incompatible add-ons should no longer be forcefully disabled.

Description of development approach
Add-ons for which compatibility should be overridden on the next restart are placed in a separate state PENDING_OVERRIDE_COMPATIBILITY. They're moved to the overridden compat state after restart. The code which enables add-ons, and verifies that given bundle can be installed has been modified to take the new state into account.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature/addon-store Features / behavior of the add-on Store p4 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation.
Projects
None yet
Milestone
2024.1
Development

Successfully merging a pull request may close this issue.

When re-installing incompatible add-ons preserve compatibility override lukaszgo1/nvda
4 participants
@seanbudd @lukaszgo1 @paulber19 @CyrilleB79