Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Action Items in iTunes not accessible #15653

Closed
bobdavcav opened this issue Oct 19, 2023 · 7 comments
Closed

Action Items in iTunes not accessible #15653

bobdavcav opened this issue Oct 19, 2023 · 7 comments
Labels
bug/regression p3 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation.
Milestone
2024.1

Comments

@bobdavcav
Copy link

Steps to reproduce:

  1. Preview a few song using iTunes. This can be done on your phone or PC, doesn't matter.
  2. On your PC, open iTunes, navigate to the store menu, and choose Wish List.
  3. Once that page opens, use heading navigation to jump down to preview history.
  4. Tab through this page. You should see a group of items associated with each song. These should be a preview button, a link presumably to take you to the album on which the song is on, and a combo box with more actions.
  5. Notice that when the combo box is encountered and you have NVDA set to automatically go into focus mode when a form field is encountered, that it does in fact do so.

Actual behavior:

When pressing down arrow from step 5 above, NVDA leaves focus mode and the combo box in question and continues navigating the page as if it was never in focus mode.

Expected behavior:

I expect to be able to interact with the combo box as I would with any other combo box.

NVDA logs, crash dumps and other attachments:

System configuration

NVDA installed/portable/running from source:

It doesn't matter whether running NVDA from a portable copy or it's installed on the system.

NVDA version:

It first appears in NVDA 2023.2, continues in NVDA 2023.3 Beta 4.

Windows version:

Edition Windows 10 Home
Version 22H2
OS build 19045.3570
Experience Windows Feature Experience Pack 1000.19052.1000.0

Name and version of other software in use when reproducing the isuld e:

I would provide the exact iTunes version, but NVDA does not read the About iTunes window.

Other information about your system:

Other questions

Does the issue still occur after restarting your computer?

Yes.

Have you tried any other versions of NVDA? If so, please report their behaviors.

The last version to behave normally was 2023.1.

If NVDA add-ons are disabled, is your problem still occurring?

I haven't tried, but would assume so.

Does the issue still occur after you run the COM Registration Fixing Tool in NVDA's tools menu?

I don't think that would make a difference, but I haven't tried.
@seanbudd
Copy link
Member

Welcome @bobdavcav ,

We are unable to process this issue as it stands.

  • Please complete the required steps for reporting an issue. Please test with add-ons disabled. Please also run the COM registration fixing tool.
  • Please reproduce this issue and provide a log file of the behaviour. Ensure your log level is set to debug in general preferences. Press NVDA+f1 when focused on the combo box control. This will log developer info for the control.
  • This is likely a problem with the implementation of iTunes. Have you tested with 2023.1 recently? Are you certain iTunes has not updated in this time?

Kind Regards,
NV Access Software Developers

@bobdavcav
Copy link
Author

bobdavcav commented Oct 24, 2023 via email

@seanbudd
Copy link
Member

as I get with my portable copy of NVDA 2023.3 beta 4 with no addons.

Does that mean you have test with add-ons disabled? If so, I will update the issue template to "Yes".

but on trying 2023.1 it worked as expected.

Does that mean you have tested again with 2023.1 after you installed 2023.2?

When possible, can you please address these extra items

  • Please complete the required steps for reporting an issue. Please test with add-ons disabled. Please also run the COM registration fixing tool.
  • Please reproduce this issue and provide a log file of the behaviour. Ensure your log level is set to debug in general preferences. Press NVDA+f1 when focused on the combo box control. This will log developer info for the control.

@bobdavcav
Copy link
Author

bobdavcav commented Oct 26, 2023 via email

@seanbudd seanbudd added bug/regression triaged Has been triaged, issue is waiting for implementation. labels Nov 3, 2023
@seanbudd seanbudd added this to the 2024.1 milestone Nov 3, 2023
@seanbudd seanbudd added the p3 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority label Nov 3, 2023
@seanbudd
Copy link
Member

seanbudd commented Dec 8, 2023 •
edited

@bobdavcav - can you please complete the additional steps outlined in #15653 (comment) ?

I'm unable to reproduce this issue as iTunes won't let me open the wishlist, throwing a consistent error.
Are there other controls that are inaccessible that I can test against?

@seanbudd seanbudd added the blocked/needs-info The issue can not be progressed until more information is provided. label Dec 8, 2023
@seanbudd seanbudd removed this from the 2024.1 milestone Dec 10, 2023
@bobdavcav
Copy link
Author

bobdavcav commented Dec 14, 2023 via email

@seanbudd
Copy link
Member

I did not get a clear answer to my question,
running a copy of NVDA without addons is functionally the same as
running one with addons disabled, right?

Yep that's the case - so no need to retest.
I've reproduced the issue now so there is no need for a log.

I managed to confirm this issue by attempting to navigating to the actions for a song. The menu is unusable.
This is definitely a regression from 2023.1, which I tested and could read the action items correctly.

@seanbudd seanbudd added this to the 2024.1 milestone Dec 19, 2023
@seanbudd seanbudd removed the blocked/needs-info The issue can not be progressed until more information is provided. label Dec 19, 2023
@michaelDCurran michaelDCurran mentioned this issue Jan 9, 2024
Merged
5 tasks
Adriani90 pushed a commit to Adriani90/nvda that referenced this issue Mar 13, 2024
@michaelDCurran @Adriani90
i15653: better handle opening combo boxes in browse mode with automat…
0b35f5d 
…ically focus focusable elements disabled (nvaccess#16016)

Fixes nvaccess#15653

Summary of the issue:
Two bugs are seen if automatically focus focus elements in browse mode is disabled. Possibly introduced when that setting was introduced, and made worse when browse mode focus code was further refacted in nvaccess#14611.

In iTunes, arrowing up and down inside a combo box incorrectly switches back to browse mode.
In Firefox / Chrome, closing a combo box does not automatically switch back to browse mode.
Description of user facing changes
NVDA will again switch back to browse mode when closing combo boxes with escape or alt+upArrow in Firefox or Chrome. (Action Items in iTunes not accessible nvaccess#15653)
Arrowing up and down in combo boxes in iTunes will no longer inappropriately switch back to browse mode. (Action Items in iTunes not accessible nvaccess#15653)
Description of development approach
BrowseModeDocument's collapseOrExpandControl script: if automatic focus focusable elements is disabled, delay the rest of the script to give time for the control to actually get focus.

Webkit (iTunes) virtualBuffer: do not treat the list items of a combo box as being part of the virtualBuffer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug/regression p3 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation.
Projects
None yet
Milestone
2024.1
Development

No branches or pull requests
2 participants
@seanbudd @bobdavcav