Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to show the minimum and last tested NVDA versions of an add-on in the descriptions of the add on store. #15776

Closed
GeorgeWu3 opened this issue Nov 12, 2023 · 9 comments · Fixed by #16053
Closed

Ability to show the minimum and last tested NVDA versions of an add-on in the descriptions of the add on store. #15776

GeorgeWu3 opened this issue Nov 12, 2023 · 9 comments · Fixed by #16053
Labels
feature/addon-store Features / behavior of the add-on Store p5 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation.
Milestone
2024.2

Comments

@GeorgeWu3
Copy link

Is your feature request related to a problem? Please describe.

no

Describe the solution you'd like

It will be nice if the add on store displays the minimum and last tested NVDA versions of an add-on in the description field. The only way I can check it is to go to the about add on button on a downloaded add on I have installed externally, or I downloaded an add on in Github from the add-on stores github page.

Describe alternatives you've considered

Additional context
@Adriani90
Copy link
Collaborator

With NVDA 2023.3, In the addon store when you focus an addon and press tab multiple times, there are two edit fields. one for the description and one for "more details". In the edit field for more details you can read the minimum and the last tested NVDA version of the currently focused addon. So it works as expected. Closing as works for me.

@GeorgeWu3
Copy link
Author

Doesn't show up on any of the add-ons when I hit down arrow on the more details field.

@Adriani90
Copy link
Collaborator

Are you looking on addons which are available? or on addons which are incompatible? This information is only available for addons with status incompatible. Fir addons with status "available", the minimum and the last tested NVDA version is the current NVDA version you are running on your system so it doesn't show up in the more details field.

@GeorgeWu3
Copy link
Author

I'm browsing through addons that are compatible.
I wish it shows the minimum and last tested NVDA versions on add-ons that are compatible.

@Adriani90
Copy link
Collaborator

Could you explain more exactly the use case for what you need this? The minimum version and the last tested version are the same when the addon is compatible. And this is the NVDA version you have installed on your system if the addon is shown as compatible.

@lukaszgo1
Copy link
Contributor

I see several reasons why the info should be shown regardless if the add-on is compatible or not:

  • In the old add-ons manager it was possible to show the compatibility range from the about add-on dialog for all add-ons, so the current state can be theoretically considered a regression
  • If I have a friend who is, for whatever reason, using older NVDA and I want to recommend a cool add-on I found to them, it is useful to see what is the minimum NVDA version required by the add-on
  • When I'm on NVDA 2023.3 and considering upgrade to 2024.1, it is also useful to look at the last tested for my most important add-ons, to asses if I can safely upgrade, or if it is still too early, as my add-ons are not compatible yet

@Adriani90 Adriani90 reopened this Nov 18, 2023
@GeorgeWu3
Copy link
Author

Some people, like me, arcurious to know what is the minimum NVDA version of a particular add on is. That's why.

@seanbudd seanbudd added p5 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation. feature/addon-store Features / behavior of the add-on Store labels Nov 21, 2023
@Nael-Sayegh
Copy link
Contributor

Hello,
I agree with @lukaszgo1, the ability to display both the minimum version and the last tested version for an available extension has several advantages.
It would be very interesting to have it shown in the more details field.

@CyrilleB79
Copy link
Collaborator

@Adriani90 wrote:

The minimum version and the last tested version are the same when the addon is compatible. And this is the NVDA version you have installed on your system if the addon is shown as compatible.

To avoid confusion, I'd like to report that this statement is not correct at all.
For example, I am running NVDA 2023.3 and have Outlook Extended add-on version 2.3. Looking at the manifest, you will see that the minimum compatible NVDA version is 2019.3 and the last tested NVDA version is 2023.1. Still it is running and not incompatible.

@lukaszgo1 has listed various reasons to support the current request. Among those:

  • If I have a friend who is, for whatever reason, using older NVDA and I want to recommend a cool add-on I found to them, it is useful to see what is the minimum NVDA version required by the add-on

This information may be useful in some cases. But beware that this information is not complete to know if you can recommend the add-on to your friend.
E.g. Windows App Essential add-on version 24.01.1 is compatible with 2023.3 only. So running NVDA 2023.3, you will see that the add-on has last tested NVDA version to 2023.3 and min NVDA version to 2023.3.
Though, I am sure that running NVDA 2023.2, you will find an older version of this add-on in the store.

Even if it should not be the main use case, another use case is for add-on developers. As an add-on developer or tester, I do not count anymore the number of time I have had to go to see the manifest of an add-on since the Add-on Store is in place; before, I was using the "About" dialog of the Add-on Manager.

@Nael-Sayegh Nael-Sayegh mentioned this issue Jan 16, 2024
Merged
5 tasks
seanbudd pushed a commit that referenced this issue Jan 23, 2024
@Nael-Sayegh
Adding the minimum version and the latest tested version of NVDA for …
5b4ecef 
…add-on (#16053)

closes #15776

Summary of the issue:
Having the ability to see the minimum version and the latest tested version of NVDA for an extension in the addonStore.

Description of user facing changes
In the addonStore, the user will be able to see the minimum version and the latest tested version of NVDA in the details of an extension.

Description of development approach
Added in the source file\gui\addonStoreGui\controls\details.py in the refresh method, I added compatibility information under the installed version of the module.
@nvaccessAuto nvaccessAuto added this to the 2024.2 milestone Jan 23, 2024
Nael-Sayegh added a commit to Nael-Sayegh/nvda that referenced this issue Feb 15, 2024
@Nael-Sayegh
Adding the minimum version and the latest tested version of NVDA for …
d2dcb0c 
…add-on (nvaccess#16053)

closes nvaccess#15776

Summary of the issue:
Having the ability to see the minimum version and the latest tested version of NVDA for an extension in the addonStore.

Description of user facing changes
In the addonStore, the user will be able to see the minimum version and the latest tested version of NVDA in the details of an extension.

Description of development approach
Added in the source file\gui\addonStoreGui\controls\details.py in the refresh method, I added compatibility information under the installed version of the module.
@nvdaes nvdaes mentioned this issue Feb 17, 2024
Closed
SaschaCowley pushed a commit to SaschaCowley/nvda that referenced this issue Feb 27, 2024
@Nael-Sayegh
Adding the minimum version and the latest tested version of NVDA for …
f8e9c62 
…add-on (nvaccess#16053)

closes nvaccess#15776

Summary of the issue:
Having the ability to see the minimum version and the latest tested version of NVDA for an extension in the addonStore.

Description of user facing changes
In the addonStore, the user will be able to see the minimum version and the latest tested version of NVDA in the details of an extension.

Description of development approach
Added in the source file\gui\addonStoreGui\controls\details.py in the refresh method, I added compatibility information under the installed version of the module.
Adriani90 pushed a commit to Adriani90/nvda that referenced this issue Mar 13, 2024
@Nael-Sayegh @Adriani90
Adding the minimum version and the latest tested version of NVDA for …
bcff37e 
…add-on (nvaccess#16053)

closes nvaccess#15776

Summary of the issue:
Having the ability to see the minimum version and the latest tested version of NVDA for an extension in the addonStore.

Description of user facing changes
In the addonStore, the user will be able to see the minimum version and the latest tested version of NVDA in the details of an extension.

Description of development approach
Added in the source file\gui\addonStoreGui\controls\details.py in the refresh method, I added compatibility information under the installed version of the module.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature/addon-store Features / behavior of the add-on Store p5 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation.
Projects
None yet
Milestone
2024.2
Development

Successfully merging a pull request may close this issue.

Adding the minimum version and the latest tested version of NVDA for add-on Nael-Sayegh/nvda
7 participants
@seanbudd @lukaszgo1 @nvaccessAuto @CyrilleB79 @Adriani90 @Nael-Sayegh @GeorgeWu3