Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The object shortcut key of a nvdaControls.CustomCheckListBox is not spoken by NVDA #15816

Closed
paulber19 opened this issue Nov 23, 2023 · 4 comments · Fixed by #15826
Closed

The object shortcut key of a nvdaControls.CustomCheckListBox is not spoken by NVDA #15816

paulber19 opened this issue Nov 23, 2023 · 4 comments · Fixed by #15826
Labels
p5 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation.
Milestone

Comments

@paulber19
Copy link

Steps to reproduce:

Actual behavior:

In nvda settings, Check the "Report object shortcut keys" option of "Object Presentation" category.

  • go to NVDA settings and "Keyboard" category.
  • press "tab" twice.
  • NVDA says:
    "Select NVDA Modifier Keys list"
    "caps lock check box checked"
    The sshortcut key "alt+s" is not spoken.

Expected behavior:

NVDA should say:
"Select NVDA Modifier Keys list alt+s"
"caps lock check box checked"

NVDA logs, crash dumps and other attachments:

System configuration

NVDA installed/portable/running from source:

Installed and portable

NVDA version:

NVDA 2023.1, 2023.2 2023.3

Windows version:

Windows 10 22H2 (10.0.19045) workstation AMD64

Name and version of other software in use when reproducing the issue:

None

Other information about your system:

Other questions

Does the issue still occur after restarting your computer?

Yes

Have you tried any other versions of NVDA? If so, please report their behaviors.

If NVDA add-ons are disabled, is your problem still occurring?

Yes

Does the issue still occur after you run the COM Registration Fixing Tool in NVDA's tools menu?

Yes

@CyrilleB79
Copy link
Collaborator

To know the shortcut of a list, you can use the following workaround:
When a list item is focused, object navigate to its parent pressing NVDA+pavNum8; this way, when the navigator object is on the whole list, the shortcut key is reported.

Note that the issue does only apply to CustomCheckListBox but also to other lists, at list in NVDA GUI:

  • List of categories in the settings dialog
  • List of symbols in the Punctuation/symbol pronunciation dialog.
  • List of add-ons in the Add-on Store

The case of the dictionary entries list is a little more strange:
The list is first focused globally when the dialog is opened and when you tab / shift+tab in it. However, once you focus one item in the list, e.g. using arrows, you cannot focus anymore the whole list again.

To summarize, in the case of lists, the shortcut is not reported because the list item is focused, not the whole list.

Usually we do not report the shortcut key of a container when it is entered. I think that it would make sense to do an exception for lists.

1 similar comment
@CyrilleB79
Copy link
Collaborator

To know the shortcut of a list, you can use the following workaround:
When a list item is focused, object navigate to its parent pressing NVDA+pavNum8; this way, when the navigator object is on the whole list, the shortcut key is reported.

Note that the issue does only apply to CustomCheckListBox but also to other lists, at list in NVDA GUI:

  • List of categories in the settings dialog
  • List of symbols in the Punctuation/symbol pronunciation dialog.
  • List of add-ons in the Add-on Store

The case of the dictionary entries list is a little more strange:
The list is first focused globally when the dialog is opened and when you tab / shift+tab in it. However, once you focus one item in the list, e.g. using arrows, you cannot focus anymore the whole list again.

To summarize, in the case of lists, the shortcut is not reported because the list item is focused, not the whole list.

Usually we do not report the shortcut key of a container when it is entered. I think that it would make sense to do an exception for lists.

@amirmahdifard
Copy link

@CyrilleB79 also, the list in the configuration dialog doesn't have any lable: it just says list: and then the item in the list: it should have a lable such as profiles list

@CyrilleB79
Copy link
Collaborator

@CyrilleB79 also, the list in the configuration dialog doesn't have any lable: it just says list: and then the item in the list: it should have a lable such as profiles list

That's true but that's a separate issue with respect to the current one; please open a new issue if it is important for you; note that there may be other unlabeled lists in the GUI; if you open an issue for this, a list of the unlabeled lists would be helpful.

@seanbudd seanbudd added p5 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation. labels Nov 27, 2023
seanbudd pushed a commit that referenced this issue Nov 27, 2023
Closes #15816

Summary of the issue:
When the focus enters in a list, the list's keyboard shortcut is not reported. It's because a list item takes the focus, whereas the shortcut key is on the whole list; logically, individual list items have no shortcut. We usually do not report shortcut keys when entering container objects. However, in the case of list, it would be useful so that people know that the list has a shortcut key.

Description of user facing changes
Reports shortcut when the focus enters a list.

Description of development approach
When speaking an object for FOCUS_ENTERED reason, if the object is a list, we do not discard keyboard shortcut anymore.

While at it, removed the accelerator of path selection in the "Create portable NVDA" dialog, since I have realized during the investigation for this PR that it was not working. A better solution would be to have a working key accelerator for this field but I do not know how to do this
@nvaccessAuto nvaccessAuto modified the milestone: 2024.1 Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p5 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants