Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Liblouis to 3.29.0 #16259

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Conversation

codeofdusk
Copy link
Contributor

Link to issue number:

None

Summary of the issue:

Liblouis 3.29.0 has been released.

Description of how this pull request fixes the issue:

Update Liblouis to 3.29.0, adding/updating Braille table definitions.

Testing strategy:

Verified that new tables appear in UI.

Known issues with pull request:

None known

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@codeofdusk codeofdusk requested a review from a team as a code owner March 4, 2024 15:57
@codeofdusk codeofdusk requested a review from seanbudd March 4, 2024 15:57
@seanbudd seanbudd added the conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review. label Mar 4, 2024
Copy link
Member

@seanbudd seanbudd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @codeofdusk

@seanbudd seanbudd merged commit dc25161 into nvaccess:master Mar 5, 2024
1 check passed
@nvaccessAuto nvaccessAuto added this to the 2024.2 milestone Mar 5, 2024
@seanbudd
Copy link
Member

@codeofdusk - do you mind adding the steps you follow to update liblouis here: https://github.com/nvaccess/nvda/blob/master/include/readme.md#liblouis

i.e. where you look out for new tables, basic steps to follow

ivnc added a commit to ivnc/nvda that referenced this pull request Apr 2, 2024
michaelDCurran pushed a commit that referenced this pull request Apr 8, 2024
)

The Liblouis braille transcriber was updated in #16259, but the newly added grc-international-es.utb table, as noted in the release notes at https://github.com/liblouis/liblouis/releases/tag/v3.29.0 (New features section), was not added to the NVDA's table list.

Description of user facing changes
New table in the table list called "Spanish for Greek text".
Changelog entry added in #16259 has been also extended to reflect this update.

Description of development approach
Call addTable() as for all other tables.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants