Add support BrailleHID protocol to BrailleEdge device

[EdKweon]

Link to issue number:

Summary of the issue:

Add support BrailleHID protocol to BrailleEdge device

Description of user facing changes

User can use BrailleEdge device using BrailleHID protocol. NVDA keys remain unchanged.

Description of development approach

Five new keys have been added. On the front edge, starting from the left, there is the leftCursor key, in the center there is the home key, and on the far right there is the rightCursor key. On the top surface, there are control and alt keys on both sides of the spacebar. Additional gesture key mappings can be added to the gesture map based on user demand.

Testing strategy:

Unit test, Lint test, System test.

Known issues with pull request:

No.

Code Review Checklist:

• Documentation:
  • Change log entry
  • User Documentation
  • Developer / Technical Documentation
  • Context sensitive help for GUI changes
• Testing:
  • Unit tests
  • System (end to end) tests
  • Manual testing
• UX of all users considered:
  • Speech
  • Braille
  • Low Vision
  • Different web browsers
  • Localization in other languages / culture than English
• API is compatible with existing add-ons.
• Security precautions taken.

[EdKweon]

NVDA gesture and key remain unchanged. There are no updated in userGuide.
Thanks!

[AppVeyorBot]

• PASS: Translation comments check.
• PASS: Unit tests.
• PASS: Lint check.
• FAIL: System tests (tags: installer NVDA). See test results for more information.
• Build (for testing PR): https://ci.appveyor.com/api/buildjobs/ics2v1ekrwc5giyx/artifacts/output/nvda_snapshot_pr16279-31364,3377ac02.exe
• CI timing (mins):
  INIT 0.0,
  INSTALL_START 1.1,
  INSTALL_END 1.0,
  BUILD_START 0.0,
  BUILD_END 30.7,
  TESTSETUP_START 0.0,
  TESTSETUP_END 0.4,
  TEST_START 0.0,
  TEST_END 2.6,
  FINISH_END 0.2

See test results for failed build of commit 3377ac025c

[LeonarddeR]

I assume this is a custom HID protocol, i.e. not the generic protocol as used by the hidBrailleStandard driver?

[EdKweon]

@LeonarddeR

I assume this is a custom HID protocol, i.e. not the generic protocol as used by the hidBrailleStandard driver?

We use hidBrailleStandard driver in device. Is there any reason you think so?

[AppVeyorBot]

• PASS: Translation comments check.
• PASS: Unit tests.
• FAIL: Lint check. See test results for more information.
• PASS: System tests (tags: installer NVDA).
• Build (for testing PR): https://ci.appveyor.com/api/buildjobs/op2b5qcqwci5bw7j/artifacts/output/nvda_snapshot_pr16279-31387,2eae9a19.exe
• CI timing (mins):
  INIT 0.0,
  INSTALL_START 1.0,
  INSTALL_END 0.9,
  BUILD_START 0.0,
  BUILD_END 27.4,
  TESTSETUP_START 0.0,
  TESTSETUP_END 0.3,
  TEST_START 0.0,
  TEST_END 2.3,
  FINISH_END 0.2

See test results for failed build of commit 2eae9a19cf

[LeonarddeR]

We use hidBrailleStandard driver in device.

In that case, what is the point of changing the hims driver?

[EdKweon]

We use hidBrailleStandard driver in device.

In that case, what is the point of changing the hims driver?

The intention is to support HID rather than to change it. There are users who want HID support. Our device driver testing has been completed on iPhones and MacBooks, so validation for the current device driver is complete.
If I have misunderstood or provided a different response, please let me know, and I would appreciate the opportunity to correct it. Thank you.

[EdKweon]

@seanbudd
I'm really sorry for not check about error before merge. There are error in class with non defined class member variable. I made a another pull reqeust about this issue.