Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix himsBrailleDisplayDriver code error #16306

Merged
merged 12 commits into from Mar 15, 2024

Conversation

EdKweon
Copy link
Contributor

@EdKweon EdKweon commented Mar 15, 2024

Link to issue number:

Summary of the issue:

There is issue that undefined class member variable.

Description of user facing changes

User can use NVDA Hims Display driver normally. (HID, Bulk, and Serial)

Description of development approach

Nothing to approach. Just fix error that not defined class member variable.

Testing strategy:

lint, system, unit

Known issues with pull request:

#16279

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@EdKweon EdKweon requested a review from a team as a code owner March 15, 2024 04:39
@EdKweon EdKweon changed the title Fix himsDisplay code error Fix himsBrailleDisplayDriver code error Mar 15, 2024
@seanbudd seanbudd merged commit def4f33 into nvaccess:master Mar 15, 2024
1 check passed
@nvaccessAuto nvaccessAuto added this to the 2024.2 milestone Mar 15, 2024
@EdKweon EdKweon deleted the FIX_HIMS_HID_CODE_ERROR branch March 15, 2024 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants