Enter focus mode when activating editable list #16325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #13642
Summary of the issue:
In Firefox, pressing enter on a list item in an editable region does not switch to focus mode.
Description of user facing changes
NVDA will switch to focus mode when pressing enter on an editable list item.
Description of development approach
Restricted the cases in which NVDA will drop the
controlTypes.State.EDITABLEto exclude objects with a role ofcontrolTypes.Role.LISTandLISTITEM.Testing strategy:
Tested using the test case given in #13642. Tested in a Google sheet with Braille mode enabled to make sure this does not regress changes implemented in #7935.
Known issues with pull request:
None
Code Review Checklist: