Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display a confirmation dialogue on activating the commands "Reset configuration to factory defaults" and "Revert to saved configuration" #16373

Closed
kara-louise opened this issue Apr 8, 2024 · 12 comments

Comments

@kara-louise
Copy link

Is your feature request related to a problem? Please describe.

Currently, after executing the "Reset configuration to factory defaults" command, it is carried out with no confirmation dialogue. This can be a problem if it was done accidentally, e.g. by pressing the wrong key while in the NVDA menu. This could be even more of an issue if someone quits NvA with the option "Save configuration when exiting NVDA" enabled, and has probably forgot or is unaware of it. They could then inadvertently overwrite their settings they have spent years customising.
Slightly less of an issue is that the "Revert to saved configuration" command also has no confirmation dialogue

Describe the solution you'd like

For both commands, Display a dialogue asking the user if they're sure they want to proceed with yes and no buttons. Also, have no shortcut keys assigned to them by default.

Describe alternatives you've considered

None.

Additional context

I have heard of a user who activated "Reset configuration to factory defaults" by accident but luckilly realised and was able to use the revert option.

@Adriani90
Copy link
Collaborator

dialog for reset to factory defaults is covered in #6648. That issue contains already valuable information for implementing this. Please limit this issue description to revert to saved configuration since there is no issue opened for that yet.

@XLTechie
Copy link
Collaborator

XLTechie commented Apr 8, 2024 via email

@XLTechie
Copy link
Collaborator

XLTechie commented Apr 8, 2024 via email

@kara-louise
Copy link
Author

To the yes and no buttons? Or to the reset functions themselves?
I meant the reset functions.

@kara-louise
Copy link
Author

regarding your second comment @XLTechie I didn't think of that issue. You're right, that would be a problem.

@kara-louise
Copy link
Author

dialog for reset to factory defaults is covered in #6648.

@Adriani90 I searched for Reset configuration to factory defaults before creating this issue but didn't see the one you mentioned. Any tips for searching for issues on here would be greatly appreciated since I seem to be creating a lot of duplicates recently.

@Adriani90
Copy link
Collaborator

Adriani90 commented Apr 8, 2024 via email

@Adriani90
Copy link
Collaborator

Adriani90 commented Apr 8, 2024 via email

@kara-louise
Copy link
Author

Thanks for those tips @Adriani90.

@kara-louise
Copy link
Author

regarding your second comment @XLTechie I didn't think of that issue. You're right, that would be a problem.
Or, have a command that just resets the volume.

@XLTechie
Copy link
Collaborator

XLTechie commented Apr 8, 2024 via email

@gerald-hartig
Copy link
Collaborator

Closing as this is the desired behaviour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants