Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Reset configuration to factory defaults" would need a confirmation dialog. #6648

Open
MichelSuch opened this issue Dec 17, 2016 · 20 comments
Open
Labels
enhancement good first issue github features these at https://github.com/nvaccess/nvda/contribute p4 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation.

Comments

@MichelSuch
Copy link
Contributor

MichelSuch commented Dec 17, 2016

When in the NVDA menu, some user sometimes incidentally press the R key (or its equivalent key in other languages) whici resets NVDA to factory defaults.
Some are not able to reconfigure NVDA by themselves, and, in any case, it can take some times to get back to the wanted configuration.
So, it would be nice if this reset function could have a confirmation dialog when the key is pressed.

Refer to #6648 (comment), #6648 (comment) for implementation details

@LeonarddeR
Copy link
Collaborator

LeonarddeR commented Dec 17, 2016 via email

@Brian1Gaff
Copy link

Brian1Gaff commented Dec 17, 2016 via email

@MichelSuch
Copy link
Contributor Author

MichelSuch commented Dec 17, 2016 via email

@jcsteh
Copy link
Contributor

jcsteh commented Dec 18, 2016 via email

@feerrenrut
Copy link
Contributor

Perhaps we could display a dialog after the reset. Informing users of what happened and how to revert to the previously saved configuration.

@derekriemer
Copy link
Collaborator

derekriemer commented Dec 19, 2016 via email

@derekriemer
Copy link
Collaborator

derekriemer commented Dec 19, 2016 via email

@MichelSuch
Copy link
Contributor Author

MichelSuch commented Dec 19, 2016 via email

@feerrenrut
Copy link
Contributor

If everyone is happy with this UX then I will set this to priority 3.

@feerrenrut feerrenrut added enhancement p4 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority labels Dec 21, 2016
@MichelSuch
Copy link
Contributor Author

MichelSuch commented Dec 21, 2016 via email

@LeonarddeR
Copy link
Collaborator

LeonarddeR commented Dec 21, 2016 via email

@LeonarddeR
Copy link
Collaborator

After discussing this with @dkager, I think it is useless to add a confirmation prompt in case of triple nvda+ctrl+r. This is a hotkey which is quite difficult to press unintentionally, so people using this hotkey do know what they're doing. Furthermore, after another nvda+ctrl+r, they are back to the last saved configuration. The dialog can be shown before the reset in the case that only the menu item will make it show up.

@MichelSuch
Copy link
Contributor Author

Yes, in fact the original idea was to bring up this dialog when performing reset from the NVDA menu, which may result of a non intentionnal key press.

@dkager
Copy link
Collaborator

dkager commented Mar 5, 2017

I agree with @LeonarddeR. The primary scenario for me is that I want to press NVDA+N, P, R but accidentally leave out the P.
To restore the config through the menu, I would say memorizing NVDA+N, R, Enter (to confirm) isn't harder than if you leave out the Enter at the end. Of course the user has to know that a confirmation dialog will pop up, but that can be added to the user guide.

@bhavyashah
Copy link

We still have some debate with regards to the UX of this suggestion. Thoughts/inputs? @jcsteh @LeonarddeR @dkager and other participants...

@LeonarddeR
Copy link
Collaborator

If all who were involved in the discussion agree that a confirmation dialog would be helpful in the case that this option is activated from the menu, that would help. Still, I belief that a confirmation is not necessary in case of a triple nvda+control+r.

@Qchristensen
Copy link
Member

I agree with all the conversation to date, I think EITHER show a prompt after resetting (however the reset is activated) with options to undo or ok. or have the option to show a prompt only when resetting from the menu. I tend to favour the first option. I think it's unlikely you'll inadvertently reset to factory defaults using the keystroke, but you shouldn't need to do it so often than an extra prompt is that much of a hassle. It is more likely that a user might accidentally trigger the menu option. I was also thinking that putting a prompt before the reset only when triggered via the menu option could still cause problems, as you might mess up the voice and be unable to understand it, but remember how to get to the option via the menu rather than the keystroke.

@Qchristensen
Copy link
Member

In looking at a couple of other settings screens not currently covered by the reset to factory defaults, I found:

Additionally, I would like to propose here, that when implementing a dialog confirmation for resetting to factory defaults, that the dialog offer checkboxes to also reset speech dictionaries, symbol pronunciation and input gestures.

Finally, a checkbox could also be included to disable all add-ons, as per #10134

@LittleStar-VIP
Copy link

I just press the reset configuration to factory default by accident.
I really would like nvda to have a double confirmation before it really applys reset.

@seanbudd seanbudd added good first issue github features these at https://github.com/nvaccess/nvda/contribute triaged Has been triaged, issue is waiting for implementation. labels May 13, 2022
@Adriani90
Copy link
Collaborator

#16373 has been also closed due to the concerns already covered in this issue. I think a dialog is tricky to implement here because either speech or braille could be set in wrong language or could be broken at all so the dialog becomes unusable.
I am in favor of just displaying a dialog after settings have been reset, as proposed by Reef and Derek in #6648 (comment)
and next.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement good first issue github features these at https://github.com/nvaccess/nvda/contribute p4 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation.
Projects
None yet
Development

No branches or pull requests