Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NVDA Python console loses unexecuted command #16653

Closed
cary-rowen opened this issue Jun 5, 2024 · 2 comments · Fixed by #16654
Closed

NVDA Python console loses unexecuted command #16653

cary-rowen opened this issue Jun 5, 2024 · 2 comments · Fixed by #16654
Assignees

Comments

@cary-rowen
Copy link
Contributor

Steps to reproduce:

  1. Open Python console
  2. Execute: regexp = r"[a-z]\d+[A-Z]"
  3. Input: regexp = r"\b\d{3}\w+\b" but do not press Enter to execute
  4. Press the up arrow once
  5. Press the down arrow once

Actual behavior:

Performing step (4): NVDA reports: regexp = r"[a-z]\d+[A-Z]"
Performing step (5): NVDA reports: "blank"

Expected behavior:

Performing step (5), NVDA reports: regexp = r"\b\d{3}\w+\b"

NVDA logs, crash dumps and other attachments:

System configuration

NVDA installed/portable/running from source:

Installed, portable

NVDA version:

2024.1

Windows version:

Windows 10 22H2 (AMD64) build 19045.4412

Name and version of other software in use when reproducing the issue:

None

Other information about your system:

None

Other questions

Does the issue still occur after restarting your computer?

Yes

Have you tried any other versions of NVDA? If so, please report their behaviors.

This is a behavior change introduced in 2024.1 by #15794,

If NVDA add-ons are disabled, is your problem still occurring?

Yes

Does the issue still occur after you run the COM Registration Fixing Tool in NVDA's tools menu?

Yes

@cary-rowen
Copy link
Contributor Author

@CyrilleB79
Is this expected?

@CyrilleB79
Copy link
Collaborator

It's a consequence of #15794 and was explicitly described in this PR.
Though I agree that it is an undesirable effect.

I'll take care of this.

@CyrilleB79 CyrilleB79 self-assigned this Jun 5, 2024
seanbudd pushed a commit that referenced this issue Jun 6, 2024
#16654)

Closes #16653

Summary of the issue:
Unexecuted commands are lost when moving in the python console history.

Description of user facing changes
If a command has been written or modified in the console but not executed, it will not be lost. In case the modified command is not the last in the history, the original history item will not be overriden (as it was before #15794), but it will be copied in last position in the history so that it can be edited.

Description of development approach
Tracked text modification with an appropriate event to react accordingly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants