-
-
Notifications
You must be signed in to change notification settings - Fork 626
-
-
Notifications
You must be signed in to change notification settings - Fork 626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trigger execution of scripts in response to keys on braille displays #209
Comments
Comment 1 by jteh on 2008-10-27 03:03
|
Comment 2 by SamuelThibault on 2008-11-06 08:56 |
Comment 3 by jteh (in reply to comment 2) on 2008-11-06 09:46
It is my attention to use this generic mapping for the BRLTTY driver. These still need to bind to scripts in NVDA, so the mechanism still needs to be developed.
I think that those using BRLTTY may already be familiar with BRLTTY key bindings, so it would be best to use those (generic) keys. Of course, some of these don't map so well to a Windows GUI screen reader and we may have to fudge this a little. |
Comment 4 by jteh on 2009-06-23 05:40 |
Comment 5 by mdcurran on 2009-12-08 02:03 |
Comment 6 by jteh on 2009-12-08 05:00 |
Comment 7 by jteh on 2010-03-18 06:57 |
Comment 10 by jteh on 2010-12-06 02:29 |
Comment 11 by jteh on 2010-12-08 08:04 The alvaBC6 driver is the only driver that has been updated so far. Mick, feel free to update the freedomScientific driver whenever you are able. |
Comment 12 by bramd on 2010-12-20 00:16 However, I also added a very basic braille input mode that allows typing braille using the braille keyboard based on the current translation table. I'm not sure yet if I can make that more generic and port it to gestures. |
Comment 13 by jteh (in reply to comment 12) on 2010-12-20 05:05
Great! Note that I haven't yet converted the existing code to use the new system. If I do, it will probably conflict with your patch. Do you want me to hold off and wait for your patch; i.e. your patch will update the driver for the new code? Note that this needs to be done fairly soon, so if you won't have time to do this soon, I'll do the initial conversion and you can submit a patch after that is done.
This should really be done in a more generic fashion and is covered by #808. I haven't really figured out how to make it more generic myself yet, as this won't be done for 2011.1. |
Comment 14 by bramd on 2010-12-23 13:47 Furthermore, please note that the hotkey for the server configuration dialog does not work yet. I have to see if I implemented the command right, did not have the time for that. This driver has been tested with the Easy Braille and should work with all Handytech devices and provide reasonable keys on all of them. Next week I've the opportunity to test more devices and expand the key assignments if needed. |
Comment 15 by jteh on 2011-01-03 23:03 |
Comment 16 by jteh on 2011-01-05 11:01 |
Comment 17 by bramd (in reply to comment 15) on 2011-01-06 12:39
Wow, I know it was late when I created the patch, but that's a big fail from me. Just updated the patch, it's against main now. I also fixed some issues regarding the config dialog, which was not working in the previous version. The driver has been tested with an Easy Braille and a Braille Star. I may add more useful key bindings later. |
Comment 18 by jteh on 2011-01-07 00:07 Some code review:
Probably more readable to set gesture to a variable here and then execute outside the if.
Probably change this to gather the keys from
Please change this to "Handy Tech" for consistency.
You can't sort the names like this for the id; they need to be in Python set order, as incoming gesture identifiers are always normalised to Python set order. I see this isn't actually documented anywhere; need to do that. :) |
Comment 19 by jteh on 2011-01-07 05:38 |
Attachment handytech-gestures.diff added by bramd on 2011-01-08 01:06 |
Comment 20 by bramd (in reply to comment 18) on 2011-01-08 01:13
Thanks, implemented your suggestions. |
Comment 21 by jteh on 2011-01-08 07:10 Closing this ticket as fixed. Technically, the lilli driver also needs updating, but this may not happen for some time and it still works as is. The core support is there, which is what this ticket was about. |
Reported by jteh on 2008-10-27 02:55
Braille display drivers call methods on braille.handler to scroll the display and perform cursor routing. However, no other keys are supported. Keys on braille displays should be able to trigger scripts in NVDA; e.g. previous line, next line, toggle tether, etc.
Blocked by #601
The text was updated successfully, but these errors were encountered: