New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The CapPitchChange setting on the Voice Settings Dialog should only be presented if the synth supports the pitch setting #2195
Comments
Attachment patch-settings-pitch.patch added by ragb on 2012-03-23 17:55 |
Comment 1 by briang1 on 2012-03-23 20:06 Changes: |
Comment 2 by jteh on 2012-03-26 00:02 |
Comment 3 by ragb (in reply to comment 2) on 2012-03-26 03:21
Sorry, Didn't know about that (synthDriverHandler.SynthDriver has no clear indication that this was possible and I haven't read all drivers...). Shall I update the interface in |
Comment 4 by jteh (in reply to comment 3) on 2012-03-26 03:32
That's what needs to be done, yes. It's a bit painful, though.
Err, I somehow missed your patch. :) I've read it now and it was the same approach I thought of before I realised it wouldn't quite work.
I don't quite follow. It's pretty ugly, but it probably does need to be handled correctly. |
Comment 5 by ragb (in reply to comment 4) on 2012-03-26 03:54
Yes, it doesn't work at all.
I was refering to adding and extra if statement to the end of the |
@jcsteh Although the original author of this ticket cannot be contacted anymore, since you were interacting earlier, could you still please respond to #2195 (comment)? |
There's not really anything to respond to. Some potential problems were noted, which I agree are certainly valid, but it's just a matter of refactoring things to get around that. |
Reported by ragb on 2012-03-23 17:54
The summary says it all... In my opinion there is no need to present capPitchChange on the voice settings Dialog when the sytnh does not supports pitch changing. This setting makes no sence in this situation and may confuse the users.
I found this when developing a new synth driver that does not support pitch.
The text was updated successfully, but these errors were encountered: