New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strange behavior when delete an add-on #3461

Closed
nvaccessAuto opened this Issue Aug 22, 2013 · 4 comments

Comments

Projects
None yet
2 participants
@nvaccessAuto

nvaccessAuto commented Aug 22, 2013

Reported by PZajda on 2013-08-22 11:02
Hi,

When I delete an add-on and restart NVDA, I though the folder would be fully deleted, so no temp directory.
But with all add-ons I tried to delete, after the first restart, I still have the tmpxxx.delete directory for each add-on.
This directory is only deleted after a second restart.
Is it the expected behavior?

I tried with an appModule which I didn't use before deleting, and with Pico I wasn't using at this moment.

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Dec 5, 2014

Comment 1 by jteh on 2014-12-05 05:15
This is due to an error in Addon.completeRemove. We're trying to rmtree the original path instead of the temp path.

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Dec 5, 2014

Comment 2 by James Teh <jamie@... on 2014-12-05 05:43
In [6733d13]:

Merge branch 't3461' into next

Incubates #3461.

Changes:
Added labels: incubating

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Jan 9, 2015

Comment 3 by James Teh <jamie@... on 2015-01-09 02:56
In [911c426]:

When removing an add-on, the add-on directory is now correctly deleted after restarting NVDA. Previously, you had to restart twice.

Addon.completeRemove was trying to remove the original path instead of the temporary rename path.
Fixes #3461.

Changes:
Removed labels: incubating
State: closed

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Jan 9, 2015

Comment 4 by jteh on 2015-01-09 02:57
Changes:
Milestone changed from None to 2015.1

@nvaccessAuto nvaccessAuto added this to the 2015.1 milestone Nov 10, 2015

jcsteh added a commit that referenced this issue Nov 23, 2015

When removing an add-on, the add-on directory is now correctly delete…
…d after restarting NVDA. Previously, you had to restart twice.

Addon.completeRemove was trying to remove the original path instead of the temporary rename path.
Fixes #3461.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment