MSHTML: XHTML completely broken #3542

Closed
nvaccessAuto opened this Issue Sep 23, 2013 · 4 comments

1 participant

@nvaccessAuto

Reported by jteh on 2013-09-23 00:52
XHTML documents break very badly with the MSHTML engine, including IE. The problem is that nodeName returns lower case names in XHTML (as per the spec), but we expect upper case, which is what is returned for normal HTML.

The simplest way to fix this is probably to upper case the node name before we use it in both the Python and C++ MSHTML code. (We could lower case everything, but that would mean a much larger diff.) For searching, I guess we'll need to search for both upper and lower case versions.

Note that in the MSHTML vbuf backend, we currently test for the math tag in lower case, as it always seems to appear like this, at least with MathPlayer installed. This will of course need to be changed if the node name is converted to upper case.

@nvaccessAuto

Comment 1 by Michael Curran <mick@... on 2013-10-02 08:20
In [afd0995]:
```CommitTicketReference repository="" revision="afd0995091597bf7c9bda753ad8d70192611bc06"
MSHTML: support xhtml documents. Specially force nodeName fetched from HTML nodes to uppercase as it seems that case can change depending on whether its HTML or XHTML. Re #3542

@nvaccessAuto

Comment 2 by Michael Curran <mick@... on 2013-10-02 08:35
In [746c47c]:
```CommitTicketReference repository="" revision="746c47cdfb7f6c38d7857a0d5d69029a6a4d7ce2"
Merge branch 't3542' into next. Incubates #3542

Changes:
Added labels: incubating
@nvaccessAuto

Comment 3 by Michael Curran <mick@... on 2013-10-15 09:48
In [bcd419f]:
```CommitTicketReference repository="" revision="bcd419f6944044fd593ffb96584d37c30fb0b74d"
Merge branch 't3542'. Fixes #3542

Changes:
Removed labels: incubating
State: closed
@nvaccessAuto

Comment 4 by mdcurran on 2013-10-15 09:48
Changes:
Milestone changed from None to 2013.3

@nvaccessAuto nvaccessAuto added this to the 2013.3 milestone Nov 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment