Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adobe Reader: Prefer name over text content for buttons #3640

Closed
nvaccessAuto opened this issue Nov 12, 2013 · 4 comments
Closed

Adobe Reader: Prefer name over text content for buttons #3640

nvaccessAuto opened this issue Nov 12, 2013 · 4 comments

Comments

@nvaccessAuto
Copy link

@nvaccessAuto nvaccessAuto commented Nov 12, 2013

Reported by jteh on 2013-11-12 06:15
Issue raised by Adobe.

For some buttons, IPDDomNode::GetTextContent returns something different to the name. GetTextContent is supposed to account for alternate and actual text, but it seems that overriding a button's name is not considered alternate/actual text. Apparently, authors can override the name using the tooltip and this is what they (and Adobe) expect an AT user to see.

I guess it makes sense to do this for all controls for which the name is generally the content; i.e. the useNameAsContent flag in the backend.

@nvaccessAuto
Copy link
Author

@nvaccessAuto nvaccessAuto commented Nov 13, 2013

Comment 2 by James Teh <jamie@... on 2013-11-13 03:12
In [d196b3f]:

In browse mode in Adobe Reader, the correct text is now rendered for buttons, etc. where the label has been overridden using a tooltip or other means.

In the backend, where useNameAsContent is true, IPDDomNode::GetName is now tried before IPDDomNode::GetTextContent.
Re #3640.

@nvaccessAuto
Copy link
Author

@nvaccessAuto nvaccessAuto commented Nov 13, 2013

Comment 3 by James Teh <jamie@... on 2013-11-13 03:13
In [d6ad6ba]:

Merge branch 't3640' into next

Incubates #3640.

Changes:
Added labels: incubating

@nvaccessAuto
Copy link
Author

@nvaccessAuto nvaccessAuto commented Nov 26, 2013

Comment 6 by James Teh <jamie@... on 2013-11-26 22:59
In [0b55f19]:

In browse mode in Adobe Reader, the correct text is now rendered for buttons, etc. where the label has been overridden using a tooltip or other means.

In the backend, where useNameAsContent is true, IPDDomNode::GetName is now tried before IPDDomNode::GetTextContent.
Fixes #3640.

Changes:
Removed labels: incubating
State: closed

@nvaccessAuto
Copy link
Author

@nvaccessAuto nvaccessAuto commented Nov 26, 2013

Comment 7 by jteh on 2013-11-26 23:04
Changes:
Milestone changed from next to 2014.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants