New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automatically report when AC is plugged in or unplugged #4612

Closed
nvaccessAuto opened this Issue Nov 9, 2014 · 6 comments

Comments

Projects
None yet
3 participants
@nvaccessAuto

nvaccessAuto commented Nov 9, 2014

Reported by blindbhavya on 2014-11-09 13:51
So, some days ago, I was testing whether a plugpoint worked or not, and therefoe needed to constantly check the battery status, while the sighted person with me's focus was only on the icon.
So, of course the sighted person detected the change faster.
Therefore, it would have been good if NVDA would have automatically reported if AC had been plugged in or unplugged.
This is similar to the ticket about reporting changes in screen orientation.

@nvaccessAuto

This comment has been minimized.

Show comment
Hide comment
@nvaccessAuto

nvaccessAuto Nov 9, 2014

Comment 1 by jteh on 2014-11-09 22:16
Could be worth doing, but not as important as screen orientation because:

  1. You can quickly check the battery status with one key command.
  2. A change in screen orientation is clearly and immediately obvious to any user who isn't blind. A change in whether AC is connected is not so obvious even to sighted users unless they're looking at the icon.

I'd love to suggest you could just focus on the power icon in the notification area and it would tell you when the text changes, but unfortunately, it seems Windows doesn't bother to fire appropriate events when it updates, which is irritating.

nvaccessAuto commented Nov 9, 2014

Comment 1 by jteh on 2014-11-09 22:16
Could be worth doing, but not as important as screen orientation because:

  1. You can quickly check the battery status with one key command.
  2. A change in screen orientation is clearly and immediately obvious to any user who isn't blind. A change in whether AC is connected is not so obvious even to sighted users unless they're looking at the icon.

I'd love to suggest you could just focus on the power icon in the notification area and it would tell you when the text changes, but unfortunately, it seems Windows doesn't bother to fire appropriate events when it updates, which is irritating.

@derekriemer

This comment has been minimized.

Show comment
Hide comment
@derekriemer

derekriemer Aug 30, 2016

Collaborator

So it turns out that @tspivey did this work in an add-on called powerNotify, that he wrote as a proof of concept, and then abandoned. He also implemented a beep when the screen is locked. This uses a message window (Like the one in core.py). I propose adding this functionality into core. (It's a minor issue, and I'd be happy to implement it).

Collaborator

derekriemer commented Aug 30, 2016

So it turns out that @tspivey did this work in an add-on called powerNotify, that he wrote as a proof of concept, and then abandoned. He also implemented a beep when the screen is locked. This uses a message window (Like the one in core.py). I propose adding this functionality into core. (It's a minor issue, and I'd be happy to implement it).

@josephsl

This comment has been minimized.

Show comment
Hide comment
@josephsl

josephsl Aug 30, 2016

Collaborator

Hi, if possible, can we combine this with screen orientation announcement? I thought there was a ticket somewhere. The reason for proposing this is in order to package them as a single PR, as the window can handle both if told to do so Thanks.

From: derekriemer [mailto:notifications@github.com]
Sent: Monday, August 29, 2016 7:59 PM
To: nvaccess/nvda
Subject: Re: [nvaccess/nvda] automatically report when AC is plugged in or unplugged (#4612)

So it turns out that @tspivey https://github.com/tspivey did this work in an add-on called powerNotify, that he wrote as a proof of concept, and then abandoned. He also implemented a beep when the screen is locked. This uses a message window (Like the one in core.py). I propose adding this functionality into core. (It's a minor issue, and I'd be happy to implement it).


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub #4612 (comment) , or mute the thread https://github.com/notifications/unsubscribe-auth/AHgLkIJ3KSOzeby-D0QO2ZCX1LBhNLWIks5qk5yAgaJpZM4JwGXN .Image removed by sender.

Collaborator

josephsl commented Aug 30, 2016

Hi, if possible, can we combine this with screen orientation announcement? I thought there was a ticket somewhere. The reason for proposing this is in order to package them as a single PR, as the window can handle both if told to do so Thanks.

From: derekriemer [mailto:notifications@github.com]
Sent: Monday, August 29, 2016 7:59 PM
To: nvaccess/nvda
Subject: Re: [nvaccess/nvda] automatically report when AC is plugged in or unplugged (#4612)

So it turns out that @tspivey https://github.com/tspivey did this work in an add-on called powerNotify, that he wrote as a proof of concept, and then abandoned. He also implemented a beep when the screen is locked. This uses a message window (Like the one in core.py). I propose adding this functionality into core. (It's a minor issue, and I'd be happy to implement it).


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub #4612 (comment) , or mute the thread https://github.com/notifications/unsubscribe-auth/AHgLkIJ3KSOzeby-D0QO2ZCX1LBhNLWIks5qk5yAgaJpZM4JwGXN .Image removed by sender.

@derekriemer

This comment has been minimized.

Show comment
Hide comment
@derekriemer

derekriemer Aug 30, 2016

Collaborator

Hi joseph:
Do you have code to do this? If so, feel free to send it to me (Or I can send you tilers code) and we could merge them.

Collaborator

derekriemer commented Aug 30, 2016

Hi joseph:
Do you have code to do this? If so, feel free to send it to me (Or I can send you tilers code) and we could merge them.

@josephsl

This comment has been minimized.

Show comment
Hide comment
@josephsl

josephsl Aug 30, 2016

Collaborator

Hi, will comment on screen orientation ticket (the code is part of Enhanced Touch Gestures). Thanks.

From: derekriemer [mailto:notifications@github.com]
Sent: Monday, August 29, 2016 8:07 PM
To: nvaccess/nvda
Cc: Joseph Lee; Comment
Subject: Re: [nvaccess/nvda] automatically report when AC is plugged in or unplugged (#4612)

Hi joseph:
Do you have code to do this? If so, feel free to send it to me (Or I can send you tilers code) and we could merge them.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub #4612 (comment) , or mute the thread https://github.com/notifications/unsubscribe-auth/AHgLkIwf31rvNfbGxNEMkbhTj0addACqks5qk55RgaJpZM4JwGXN .Image removed by sender.

Collaborator

josephsl commented Aug 30, 2016

Hi, will comment on screen orientation ticket (the code is part of Enhanced Touch Gestures). Thanks.

From: derekriemer [mailto:notifications@github.com]
Sent: Monday, August 29, 2016 8:07 PM
To: nvaccess/nvda
Cc: Joseph Lee; Comment
Subject: Re: [nvaccess/nvda] automatically report when AC is plugged in or unplugged (#4612)

Hi joseph:
Do you have code to do this? If so, feel free to send it to me (Or I can send you tilers code) and we could merge them.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub #4612 (comment) , or mute the thread https://github.com/notifications/unsubscribe-auth/AHgLkIwf31rvNfbGxNEMkbhTj0addACqks5qk55RgaJpZM4JwGXN .Image removed by sender.

@josephsl

This comment has been minimized.

Show comment
Hide comment
@josephsl

josephsl Aug 30, 2016

Collaborator

Hi,

@derekriemer and I have agreed to combine this and #4574 into a single PR package, using code from Tyler's implementation. Thanks.

Collaborator

josephsl commented Aug 30, 2016

Hi,

@derekriemer and I have agreed to combine this and #4574 into a single PR package, using code from Tyler's implementation. Thanks.

@nvaccessAuto nvaccessAuto added this to the 2017.4 milestone Oct 9, 2017

michaelDCurran added a commit that referenced this issue Oct 9, 2017

If you are running a laptop, NVDA will now announce changes to whethe…
…r a charger is plugged in and more. #4612 (#6320)

* If you are running a laptop, NVDA will now announce changes to whether a charger is plugged in.
Changes to the orientation of the screen are now announced, For example, turning a laptop so it is situated with the longer side horizontal, you'll hear or feel "Landscape"

* Add copyright info

* Fix gramar error

* Address review actions

* Remove the initializing cache, and add it as an argument.

* Move comment into block

* Use hiword and lowword

* Move the comment up

* Review actions, change from using an init param to using a try/except/finally

* fix this last review action
I took a longer but more clear approach.

* Fix NIT

* Add caching

* Fix review actions, and implement screen flip detection.

* Fix review actions

@josephsl josephsl referenced this issue Oct 15, 2017

Merged

Docs17.4 #7662

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment