Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reading of data: urls in images #4793

Closed
nvaccessAuto opened this issue Jan 13, 2015 · 6 comments
Closed

Reading of data: urls in images #4793

nvaccessAuto opened this issue Jan 13, 2015 · 6 comments

Comments

@nvaccessAuto
Copy link

@nvaccessAuto nvaccessAuto commented Jan 13, 2015

Reported by tspivey on 2015-01-13 02:11
Sometimes, NVDA reads data:image/* urls, such as the one in this test example.
This occurs most commonly on google groups, but I've seen it in other places.

@nvaccessAuto
Copy link
Author

@nvaccessAuto nvaccessAuto commented Jan 13, 2015

Attachment imgtest.html added by tspivey on 2015-01-13 02:12
Description:

@nvaccessAuto
Copy link
Author

@nvaccessAuto nvaccessAuto commented Jan 13, 2015

Attachment 0001-Ignore-URLs-that-start-with-data-image.patch added by tspivey on 2015-01-13 04:10
Description:

@nvaccessAuto
Copy link
Author

@nvaccessAuto nvaccessAuto commented Jan 13, 2015

Comment 2 by James Teh <jamie@... on 2015-01-13 04:56
In [2bb032f]:

In browse mode, nonsensical text (sometimes spanning several lines) is no longer presented for certain graphics such as found on Google Groups. (Specifically, this occurred with base64 encoded images.)

When determining a name from a URL, we now just return an empty string if the URL starts with data:image/.
Re #4793.

@nvaccessAuto
Copy link
Author

@nvaccessAuto nvaccessAuto commented Jan 13, 2015

Comment 3 by James Teh <jamie@... on 2015-01-13 04:56
In [d014964]:

Merge branch 't4793' into next

Incubates #4793.

Changes:
Added labels: incubating

@nvaccessAuto
Copy link
Author

@nvaccessAuto nvaccessAuto commented Jan 27, 2015

Comment 4 by James Teh <jamie@... on 2015-01-27 03:28
In [0ede342]:

In browse mode, nonsensical text (sometimes spanning several lines) is no longer presented for certain graphics such as found on Google Groups. (Specifically, this occurred with base64 encoded images.)

When determining a name from a URL, we now just return an empty string if the URL starts with data:image/.
Fixes #4793.

Changes:
Removed labels: incubating
State: closed

@nvaccessAuto
Copy link
Author

@nvaccessAuto nvaccessAuto commented Jan 27, 2015

Comment 5 by jteh on 2015-01-27 03:57
Changes:
Milestone changed from None to 2015.1

@nvaccessAuto nvaccessAuto added this to the 2015.1 milestone Nov 10, 2015
jcsteh added a commit that referenced this issue Nov 23, 2015
…s no longer presented for certain graphics such as found on Google Groups. (Specifically, this occurred with base64 encoded images.)

When determining a name from a URL, we now just return an empty string if the URL starts with data:image/.
Fixes #4793.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant