Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microsoft Excel: NVDA does not handle font and font size comboboxes in Cell Format Multi-Tab Dialog #5076

Closed
nvaccessAuto opened this issue May 4, 2015 · 11 comments

Comments

@nvaccessAuto
Copy link

Reported by msuch on 2015-05-04 17:05
Hi. In Excel, the combo box used to change the font in the "Cell Format" is not appropriately reported.
Steps to reproduce:

  1. Open a new excel sheet and activate the context menu.
  2. Arrow to then press Enter on "Cell format".
  3. In the multi-tab dialog that displays choose the Fonts tab.

Synptom: When arrowing the font list, they change but they're not spoken by NVDA, unless NVDA+arrow-up is pressed. Same goes for the font sizes on the next control that's reached through the tab key.

The colors tab, within the aforeesaid dialog is reported but it is too verbose.
Happens with: NVDA stable and Master 11017,7b4a196 Windows 7 32 bits SP1, Microsoft Office Excel 2003 and 2010. All up-to-date.
Thanks!

@nvaccessAuto
Copy link
Author

Comment 1 by Palacee_hun on 2015-05-05 10:35
I could reproduce this on Windows XP Home SP3 with Excel 2003 and NVDA 2015.1.
Just for curiosity I tested this with NVDA 2011.1 and 2011.2 (I kept these on my machine for testing regressions), and surprise: these controls report as expected when arrowing. This hints at some sort of a regression.
I also tested NVDA master-10641,d5b17df (25 December, 2014). It has the reported problem. I admit the period to scan for the regression is still quite large: more than three years.

@nvaccessAuto
Copy link
Author

Comment 2 by nvdakor on 2015-05-06 01:22
Hi,
Confirmed in Office 2013 under Windows 8.1. The dev info for Excel 2013's font list is as follows:

name: u'Font:'
role: ROLE_EDITABLETEXT
states: STATE_FOCUSABLE, STATE_FOCUSED
isFocusable: True
hasFocus: True
Python object: <NVDAObjects.Dynamic_IAccessibleDisplayModelEditableTextWindowNVDAObject object at 0x092AC930>
Python class mro: (<class 'NVDAObjects.Dynamic_IAccessibleDisplayModelEditableTextWindowNVDAObject'>, <class 'NVDAObjects.IAccessible.IAccessible'>, <class 'NVDAObjects.window.DisplayModelEditableText'>, <class 'NVDAObjects.behaviors.EditableText'>, <class 'editableText.EditableText'>, <class 'NVDAObjects.window.Window'>, <class 'NVDAObjects.NVDAObject'>, <class 'baseObject.ScriptableObject'>, <class 'baseObject.AutoPropertyObject'>, <type 'object'>)
description: None
location: (697, 83, 251, 14)
value: None
appModule: <'appModuleHandler' (appName u'excel', process ID 368) at address 9107270>
appModule.productName: u'Microsoft Office 2013'
appModule.productVersion: u'15.0.4711.1000'
TextInfo: <class 'displayModel.EditableTextDisplayModelTextInfo'>
windowHandle: 1772222
windowClassName: u'EDTBX'
windowControlID: 4667
windowStyle: 1409286272
windowThreadID: 3016
windowText: u'Agency FB'
displayText: u'Agency FB'
IAccessibleObject: <POINTER(IAccessible) ptr=0x760eb68 at 499eee0>
IAccessibleChildID: 0
IAccessible event parameters: windowHandle=1772222, objectID=-4, childID=0
IAccessible accName: u'Agency FB'
IAccessible accRole: ROLE_SYSTEM_CLIENT
IAccessible accState: STATE_SYSTEM_FOCUSED, STATE_SYSTEM_FOCUSABLE, STATE_SYSTEM_VALID (1048580)
IAccessible accDescription: None
IAccessible accValue: None

Setup: Windows 8.1 Pro, Excel 2013, NVDA next.12007.
Is this similar to an issue where we had to come up with a fix for GoldWave?
Thanks.

@nvaccessAuto
Copy link
Author

Comment 3 by nvdakor (in reply to comment 1) on 2015-05-06 01:24
Replying to Palacee_hun:

Just for curiosity I tested this with NVDA 2011.1 and 2011.2 (I kept these on my machine for testing regressions), and surprise: these controls report as expected when arrowing. This hints at some sort of a regression.

I also tested NVDA master-10641,d5b17df (25 December, 2014). It has the reported problem. I admit the period to scan for the regression is still quite large: more than three years.

What about 2012.x or 2013.x releases? We could run bisect, going through tags to see which commit caused it.
Thanks.

@nvaccessAuto
Copy link
Author

Comment 4 by Palacee_hun (in reply to comment 3) on 2015-05-06 11:55
Replying to nvdakor:

What about 2012.x or 2013.x releases? We could run bisect, going through tags to see which commit caused it.

Thanks.

2011.3 works correctly, but 2012.1, 2012.2, 2012.3 and I presume all subsequent versions do not.
I suspect the following change from the 2012.1 what's new:
•Improved tracking of the caret in editable text fields which rely on text written to the screen. In particular, this improves editing in the Microsoft Excel cell editor and the Eudora message editor. (#1658)
I note that the affected Excel controls have the WindowClass 'EDTBX' and use the display model.

@nvaccessAuto
Copy link
Author

Comment 5 by Palacee_hun on 2015-05-26 13:13
After browsing through the comments in #1658, I am almost sure that da0f762 is the culprit that is behind this regression.
That's a quite complex changeset, so it doesn't seem too easy to prove this or analyse and find out what exactly is the cause and how to fix this.
Personally I'm not really familiar with the wast internal complexities of the display model, so no further ideas for now frankly.

@nvaccessAuto
Copy link
Author

Comment 6 by jteh on 2015-05-26 23:42
I can't reproduce this with Excel 2010 in Windows 8.1. When I arrow through the list of fonts, the selected font is read as it changes.

What do you hear when you press up and down arrows? Do you simply hear nothing, blank or the font that was previously selected?

@nvaccessAuto
Copy link
Author

Comment 7 by Palacee_hun (in reply to comment 6) on 2015-05-27 07:42
Replying to jteh:

What do you hear when you press up and down arrows? Do you simply hear nothing, blank or the font that was previously selected?

I simply hear nothing.

@nvaccessAuto
Copy link
Author

Comment 8 by bdorer on 2015-05-29 18:03
Same here with Excel 2013 and with latest next version of NVDA
Further more this is reproducable in the numbers tab where you can select decimal numbers.

This works with standard Combo boxes like category selection in the numbers tab.

@bhavyashah
Copy link

CC @Qchristensen

@Adriani90
Copy link
Collaborator

Adriani90 commented Jan 28, 2019

@msuch, @josephsl, @bdorer can you still reproduce this issue? I have tested in MS Excel 2010 and 2016 and this seems solved now.

@Adriani90
Copy link
Collaborator

Closinga s works for me. Please comment on this if you still have the issue and we can reopen it. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants