New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make speech symbol preservation configurable from GUI #5234

Closed
nvaccessAuto opened this Issue Jul 20, 2015 · 7 comments

Comments

Projects
None yet
1 participant
@nvaccessAuto

nvaccessAuto commented Jul 20, 2015

Reported by jteh on 2015-07-20 06:18
(Spun off ticket:3799#comment:9.)

Currently, it's only possible to configure symbol preservation by editing symbols-xx.dic manually. While this was originally considered advanced enough that it shouldn't be included in the GUI, quite a few users seem to want this, especially given the changes introduced in #3799.

Note that this was discussed in #1597, but I've opened a new ticket, as the discussion there is a bit broader and somewhat confusing. See also this latest thread of discussion.

The option will probably be a combo box labelled "Send actual symbol to synthesizer" with values of "never", "always" and "only below symbol's level".
Blocked by #5389
Blocking #3799

@nvaccessAuto

This comment has been minimized.

Show comment
Hide comment
@nvaccessAuto

nvaccessAuto Jul 20, 2015

Comment 2 by jteh on 2015-07-20 06:21
Changes:
Milestone changed from None to 2015.4

nvaccessAuto commented Jul 20, 2015

Comment 2 by jteh on 2015-07-20 06:21
Changes:
Milestone changed from None to 2015.4

@nvaccessAuto

This comment has been minimized.

Show comment
Hide comment
@nvaccessAuto

nvaccessAuto Jul 20, 2015

Comment 3 by leonarddr on 2015-07-20 14:52
I made a seemingly succesful attempt to implement this in the t5234 branch at bitbucket.org/leonardder/nvda.git

nvaccessAuto commented Jul 20, 2015

Comment 3 by leonarddr on 2015-07-20 14:52
I made a seemingly succesful attempt to implement this in the t5234 branch at bitbucket.org/leonardder/nvda.git

@nvaccessAuto

This comment has been minimized.

Show comment
Hide comment
@nvaccessAuto

nvaccessAuto Jul 20, 2015

Comment 4 by dkager on 2015-07-20 17:41
When I expand comboboxes in this settings dialog, then tab away, the comboboxes don't collapse automatically. I also get a crash and watchdog restart when canceling out of the dialog. Maybe config file woes.

nvaccessAuto commented Jul 20, 2015

Comment 4 by dkager on 2015-07-20 17:41
When I expand comboboxes in this settings dialog, then tab away, the comboboxes don't collapse automatically. I also get a crash and watchdog restart when canceling out of the dialog. Maybe config file woes.

@nvaccessAuto

This comment has been minimized.

Show comment
Hide comment
@nvaccessAuto

nvaccessAuto Sep 21, 2015

Comment 6 by James Teh <jamie@... on 2015-09-21 06:48
In commit e624d38:
Merge branch 't5234' into next

Incubates #5234.
Changes:
Added labels: incubating

nvaccessAuto commented Sep 21, 2015

Comment 6 by James Teh <jamie@... on 2015-09-21 06:48
In commit e624d38:
Merge branch 't5234' into next

Incubates #5234.
Changes:
Added labels: incubating

@nvaccessAuto

This comment has been minimized.

Show comment
Hide comment
@nvaccessAuto

nvaccessAuto Sep 21, 2015

Comment 7 by jteh on 2015-09-21 06:49
Thanks. I changed translator comments, added user documentation and rebased/squashed.

nvaccessAuto commented Sep 21, 2015

Comment 7 by jteh on 2015-09-21 06:49
Thanks. I changed translator comments, added user documentation and rebased/squashed.

@nvaccessAuto

This comment has been minimized.

Show comment
Hide comment
@nvaccessAuto

nvaccessAuto Oct 1, 2015

Comment 8 by James Teh <jamie@... on 2015-10-01 20:27
In commit e743ce3:
Merge branch 't5234' into next: Hopefully fix crash when dismissing Symbol Pronunciation dialog

Incubates #5234. Re #5389.

nvaccessAuto commented Oct 1, 2015

Comment 8 by James Teh <jamie@... on 2015-10-01 20:27
In commit e743ce3:
Merge branch 't5234' into next: Hopefully fix crash when dismissing Symbol Pronunciation dialog

Incubates #5234. Re #5389.

@nvaccessAuto

This comment has been minimized.

Show comment
Hide comment
@nvaccessAuto

nvaccessAuto Oct 19, 2015

Comment 10 by James Teh <jamie@... on 2015-10-19 03:53
In commit eefb8ad:
It is now possible to configure whether actual symbols are sent to speech synthesizers (e.g. to cause a pause or change in inflection) in the Symbol Pronunciation dialog.

Fixes #5234.
Authors: Leonard de Ruijter alderuijter@gmail.com, James Teh jamie@nvaccess.org
Changes:
Removed labels: incubating
State: closed

nvaccessAuto commented Oct 19, 2015

Comment 10 by James Teh <jamie@... on 2015-10-19 03:53
In commit eefb8ad:
It is now possible to configure whether actual symbols are sent to speech synthesizers (e.g. to cause a pause or change in inflection) in the Symbol Pronunciation dialog.

Fixes #5234.
Authors: Leonard de Ruijter alderuijter@gmail.com, James Teh jamie@nvaccess.org
Changes:
Removed labels: incubating
State: closed

@nvaccessAuto nvaccessAuto added this to the 2015.4 milestone Nov 10, 2015

jcsteh added a commit that referenced this issue Nov 23, 2015

It is now possible to configure whether actual symbols are sent to sp…
…eech synthesizers (e.g. to cause a pause or change in inflection) in the Symbol Pronunciation dialog.

Fixes #5234.
Authors: Leonard de Ruijter <alderuijter@gmail.com>, James Teh <jamie@nvaccess.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment