New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade warning dialog is visually broken #5325

Closed
nvaccessAuto opened this Issue Aug 29, 2015 · 1 comment

Comments

Projects
None yet
3 participants
@nvaccessAuto

nvaccessAuto commented Aug 29, 2015

Reported by nishimotz on 2015-08-29 14:18
Downgrade warning dialog of NVDA 2015.3 introduced by #5037 is visually broken.
Proceed and Cancel buttons are not shown in the window correctly.

The following patch should fix this:

diff --git a/source/gui/installerGui.py b/source/gui/installerGui.py
index 8438921..4ddb712 100644
--- a/source/gui/installerGui.py
+++ b/source/gui/installerGui.py
@@ -161,8 +161,11 @@ def showInstallGui():
            # Translators: The label of a button to proceed with installation,
            # even though this is not recommended.
            label=_("&Proceed with installation (not recommended)"))
+       sizer.Add(item)
        item = wx.Button(d, id=wx.ID_CANCEL)
        item.SetFocus()
+       sizer.Add(item)
+       mainSizer.Add(sizer)
        d.Sizer = mainSizer
        mainSizer.Fit(d)
        d.Center(wx.BOTH | wx.CENTER_ON_SCREEN)

@jcsteh jcsteh removed the Untriaged label Nov 13, 2015

jcsteh added a commit that referenced this issue Nov 23, 2015

Fixed the visual appearance of the buttons in the warning dialog whic…
…h is displayed when you attempt to downgrade NVDA.

Fixes #5325.
@leonardder

This comment has been minimized.

Show comment
Hide comment
@leonardder

leonardder Jul 22, 2017

Collaborator

Hmm, this is a strange one. This should have been closed by fb00b52, but it is still open. Probably because the particular commit ended up in a squashed commit which didn't explicitly state the closure of this issue. Confirmed that this code is in master, so closing anyway.

Collaborator

leonardder commented Jul 22, 2017

Hmm, this is a strange one. This should have been closed by fb00b52, but it is still open. Probably because the particular commit ended up in a squashed commit which didn't explicitly state the closure of this issue. Confirmed that this code is in master, so closing anyway.

@leonardder leonardder closed this Jul 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment