New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NVda reads empty notifications in latest version of skype for desktop #5405

Closed
nvaccessAuto opened this Issue Oct 8, 2015 · 14 comments

Comments

Projects
None yet
2 participants
@nvaccessAuto

nvaccessAuto commented Oct 8, 2015

Reported by mojsior on 2015-10-08 06:43
I am using a latest master snapshot and the latest version of nvda and when someone on my skype changes his status nvda only speaks word alert buut not reads who was changed status for example Michael is online.
I have used a stable version of nvda with latest skype and I have had the same problem.
I am using windows 10

Blocked by #4841
Blocking #4871

@nvaccessAuto

This comment has been minimized.

Show comment
Hide comment
@nvaccessAuto

nvaccessAuto Oct 8, 2015

Comment 1 by jteh on 2015-10-08 07:03
Did this work for you in previous versions of Skype?

nvaccessAuto commented Oct 8, 2015

Comment 1 by jteh on 2015-10-08 07:03
Did this work for you in previous versions of Skype?

@nvaccessAuto

This comment has been minimized.

Show comment
Hide comment
@nvaccessAuto

nvaccessAuto Oct 8, 2015

Comment 2 by k_kolev1985 on 2015-10-08 07:10
Well, I'm not the original reporter of the bug, but I'm also experiencing it. And yes - it did work OK in previous versions of Skype. But from the last few versions of Skype, it does not. Most of the times the notifications are read as empty ones - NVDA says only "Alert" and nothing else. Sometimes NVDA reads the content of the notification as well, but rarely. And that affects not only combined notifications witch NVDA can't read from the beginning, but single notifications as well.

nvaccessAuto commented Oct 8, 2015

Comment 2 by k_kolev1985 on 2015-10-08 07:10
Well, I'm not the original reporter of the bug, but I'm also experiencing it. And yes - it did work OK in previous versions of Skype. But from the last few versions of Skype, it does not. Most of the times the notifications are read as empty ones - NVDA says only "Alert" and nothing else. Sometimes NVDA reads the content of the notification as well, but rarely. And that affects not only combined notifications witch NVDA can't read from the beginning, but single notifications as well.

@nvaccessAuto

This comment has been minimized.

Show comment
Hide comment
@nvaccessAuto

nvaccessAuto Oct 12, 2015

Comment 3 by camlorn on 2015-10-12 00:08
I can confirm everything said here. It seems to be since an update last week. I'm on Next.

nvaccessAuto commented Oct 12, 2015

Comment 3 by camlorn on 2015-10-12 00:08
I can confirm everything said here. It seems to be since an update last week. I'm on Next.

@nvaccessAuto

This comment has been minimized.

Show comment
Hide comment
@nvaccessAuto

nvaccessAuto Oct 22, 2015

Comment 4 by jteh on 2015-10-22 07:16
Changes:
Milestone changed from None to 2015.4

nvaccessAuto commented Oct 22, 2015

Comment 4 by jteh on 2015-10-22 07:16
Changes:
Milestone changed from None to 2015.4

@nvaccessAuto

This comment has been minimized.

Show comment
Hide comment
@nvaccessAuto

nvaccessAuto Oct 23, 2015

Comment 5 by jteh on 2015-10-23 02:34
It seems waiting 500 ms after the window appears is not long enough in recent versions. Rather than using a timer, a more reliable way is to use the reorder event. Since this is also needed for #4841, I've done this work as part of #4841.

nvaccessAuto commented Oct 23, 2015

Comment 5 by jteh on 2015-10-23 02:34
It seems waiting 500 ms after the window appears is not long enough in recent versions. Rather than using a timer, a more reliable way is to use the reorder event. Since this is also needed for #4841, I've done this work as part of #4841.

@nvaccessAuto

This comment has been minimized.

Show comment
Hide comment
@nvaccessAuto

nvaccessAuto Nov 4, 2015

Comment 6 by jteh on 2015-11-04 03:42
It'd be great if users who experienced this issue can report whether this fix works as expected and doesn't break anything else. We've had one report that this fix breaks some notifications, but I can't reproduce this and/or never got those notifications before anyway.

nvaccessAuto commented Nov 4, 2015

Comment 6 by jteh on 2015-11-04 03:42
It'd be great if users who experienced this issue can report whether this fix works as expected and doesn't break anything else. We've had one report that this fix breaks some notifications, but I can't reproduce this and/or never got those notifications before anyway.

@nvaccessAuto

This comment has been minimized.

Show comment
Hide comment
@nvaccessAuto

nvaccessAuto Nov 4, 2015

Comment 7 by k_kolev1985 on 2015-11-04 09:32
Yes, I can confirm that the notification that appears after a left-mouse click on the Skype tray icon is not read by NVDA. I haven't noticed this before the report from the other user, since I don't use/invoke that specific notification from Skype.

Steps to reproduce it:

  1. Launch Skype.
  2. Press Windows+B, to go to the system tray.
  3. Use the arrow keys to find the Skype icon.
  4. Press spacebar on it. That simulates a single left button click of the mouse.
    A notification will appear, but NVDA will neither say that a Skype alert has popped up, nor will read its contents.

Notes:

  • This does not occur with NVDA 2015.3, but it does with the latest "next" snapshot.
  • As far as I'm aware, the fix doesn't brake anything else in NVDA's support for Skype.

Test environment:

  • Operating system: Windows 10 Pro (build 10240), 64-bit, in Bulgarian with all locale settings set to "Bulgarian".
  • NVDA version: next-12699,b174e75, in bulgarian.
  • Skype version: 7.13.0.101, in bulgarian.

nvaccessAuto commented Nov 4, 2015

Comment 7 by k_kolev1985 on 2015-11-04 09:32
Yes, I can confirm that the notification that appears after a left-mouse click on the Skype tray icon is not read by NVDA. I haven't noticed this before the report from the other user, since I don't use/invoke that specific notification from Skype.

Steps to reproduce it:

  1. Launch Skype.
  2. Press Windows+B, to go to the system tray.
  3. Use the arrow keys to find the Skype icon.
  4. Press spacebar on it. That simulates a single left button click of the mouse.
    A notification will appear, but NVDA will neither say that a Skype alert has popped up, nor will read its contents.

Notes:

  • This does not occur with NVDA 2015.3, but it does with the latest "next" snapshot.
  • As far as I'm aware, the fix doesn't brake anything else in NVDA's support for Skype.

Test environment:

  • Operating system: Windows 10 Pro (build 10240), 64-bit, in Bulgarian with all locale settings set to "Bulgarian".
  • NVDA version: next-12699,b174e75, in bulgarian.
  • Skype version: 7.13.0.101, in bulgarian.
@nvaccessAuto

This comment has been minimized.

Show comment
Hide comment
@nvaccessAuto

nvaccessAuto Nov 4, 2015

Comment 8 by jteh on 2015-11-04 10:57
My understanding was that in NVDA 2015.3, almost all notifications were read as empty. Does this notification launched from the system tray read correctly or as empty with NVDA 2015.3?

nvaccessAuto commented Nov 4, 2015

Comment 8 by jteh on 2015-11-04 10:57
My understanding was that in NVDA 2015.3, almost all notifications were read as empty. Does this notification launched from the system tray read correctly or as empty with NVDA 2015.3?

@nvaccessAuto

This comment has been minimized.

Show comment
Hide comment
@nvaccessAuto

nvaccessAuto Nov 4, 2015

Comment 9 by k_kolev1985 on 2015-11-04 14:22
Yes, this notification reads correctly with NVDA 2015.3.

nvaccessAuto commented Nov 4, 2015

Comment 9 by k_kolev1985 on 2015-11-04 14:22
Yes, this notification reads correctly with NVDA 2015.3.

@nvaccessAuto

This comment has been minimized.

Show comment
Hide comment
@nvaccessAuto

nvaccessAuto Nov 5, 2015

Comment 10 by James Teh <jamie@... on 2015-11-05 01:19
In commit cf453a9:
Merge branch 't4841' into next: Fix reporting of the notification that appears when you click once on the Skype system tray icon.

Incubates #4841. Re #5405.

nvaccessAuto commented Nov 5, 2015

Comment 10 by James Teh <jamie@... on 2015-11-05 01:19
In commit cf453a9:
Merge branch 't4841' into next: Fix reporting of the notification that appears when you click once on the Skype system tray icon.

Incubates #4841. Re #5405.

@nvaccessAuto

This comment has been minimized.

Show comment
Hide comment
@nvaccessAuto

nvaccessAuto Nov 9, 2015

Comment 11 by James Teh <jamie@... on 2015-11-09 00:05
In commit 153a852:
In Skype for Desktop, notifications which are displayed before a previous notification disappears are now reported. Also, notifications are now correctly reported in Skype 7.12 and later.

Fixes #4841, #5405.
Changes:
State: closed

nvaccessAuto commented Nov 9, 2015

Comment 11 by James Teh <jamie@... on 2015-11-09 00:05
In commit 153a852:
In Skype for Desktop, notifications which are displayed before a previous notification disappears are now reported. Also, notifications are now correctly reported in Skype 7.12 and later.

Fixes #4841, #5405.
Changes:
State: closed

@nvaccessAuto

This comment has been minimized.

Show comment
Hide comment
@nvaccessAuto

nvaccessAuto Nov 9, 2015

Comment 12 by JamaicanUser on 2015-11-09 00:36
Should I close the ticket I raised about this issue a long time ago?

nvaccessAuto commented Nov 9, 2015

Comment 12 by JamaicanUser on 2015-11-09 00:36
Should I close the ticket I raised about this issue a long time ago?

@nvaccessAuto

This comment has been minimized.

Show comment
Hide comment
@nvaccessAuto

nvaccessAuto Nov 9, 2015

Comment 13 by jteh on 2015-11-09 01:55
Which ticket? It's probably a different (if related) issue, since Skype 7.12 was only released recently.

nvaccessAuto commented Nov 9, 2015

Comment 13 by jteh on 2015-11-09 01:55
Which ticket? It's probably a different (if related) issue, since Skype 7.12 was only released recently.

@nvaccessAuto

This comment has been minimized.

Show comment
Hide comment
@nvaccessAuto

nvaccessAuto Nov 9, 2015

Comment 14 by JamaicanUser on 2015-11-09 02:01
I was refering to #4871. However, I closed it a long time ago :)

nvaccessAuto commented Nov 9, 2015

Comment 14 by JamaicanUser on 2015-11-09 02:01
I was refering to #4871. However, I closed it a long time ago :)

@nvaccessAuto nvaccessAuto added this to the 2015.4 milestone Nov 10, 2015

jcsteh added a commit that referenced this issue Nov 23, 2015

In Skype for Desktop, notifications which are displayed before a prev…
…ious notification disappears are now reported. Also, notifications are now correctly reported in Skype 7.12 and later.

Fixes #4841, #5405.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment