New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input Gestures dialog: Typing multiple words into filter field broken #5426

Closed
nvaccessAuto opened this Issue Oct 19, 2015 · 2 comments

Comments

Projects
None yet
2 participants
@nvaccessAuto

nvaccessAuto commented Oct 19, 2015

Reported by jteh on 2015-10-19 02:15
STR:

  1. Open the Input Gestures dialog.
  2. Focus the Filter field.
  3. Type "input help" (without the quotes).
  • Expected: The tree should be filtered to contain entries containing input and help.
  • Actual: Exception.

Regression introduced by 39aa155.

@nvaccessAuto

This comment has been minimized.

Show comment
Hide comment
@nvaccessAuto

nvaccessAuto Oct 19, 2015

Comment 2 by James Teh <jamie@... on 2015-10-19 02:18
In commit d6f581c:
Merge branch 't5426' into next

Incubates #5426.
Changes:
Added labels: incubating

nvaccessAuto commented Oct 19, 2015

Comment 2 by James Teh <jamie@... on 2015-10-19 02:18
In commit d6f581c:
Merge branch 't5426' into next

Incubates #5426.
Changes:
Added labels: incubating

@nvaccessAuto

This comment has been minimized.

Show comment
Hide comment
@nvaccessAuto

nvaccessAuto Nov 1, 2015

Comment 3 by James Teh <jamie@... on 2015-11-01 22:23
In commit 775a7ea:
Fixed problems when typing multiple words into the filter field in the Input Gestures dialog.

Because we escape the regexp, we need to split on "\ ", not just " ".
Fixes #5426.
Changes:
Removed labels: incubating
State: closed

nvaccessAuto commented Nov 1, 2015

Comment 3 by James Teh <jamie@... on 2015-11-01 22:23
In commit 775a7ea:
Fixed problems when typing multiple words into the filter field in the Input Gestures dialog.

Because we escape the regexp, we need to split on "\ ", not just " ".
Fixes #5426.
Changes:
Removed labels: incubating
State: closed

@nvaccessAuto nvaccessAuto added this to the 2015.4 milestone Nov 10, 2015

jcsteh added a commit that referenced this issue Nov 23, 2015

Fixed problems when typing multiple words into the filter field in th…
…e Input Gestures dialog.

Because we escape the regexp, we need to split on "\ ", not just " ".
Fixes #5426.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment