Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add keystroke to jump to the end of landmarks #5482

Closed
sukiletxe opened this issue Nov 11, 2015 · 2 comments
Closed

add keystroke to jump to the end of landmarks #5482

sukiletxe opened this issue Nov 11, 2015 · 2 comments
Labels
feature/browse-mode
Milestone
2017.4

Comments

@sukiletxe
Copy link

Rationale: Sometimes, mostly in news sites, an aside landamark is found inside a main landmark. That makes the reading experience rather unpleasant. Adding a keyboard command to jump to the end of a landmark would improve the reading experience. Maybe it will make the announcement of the ending would make nVDA too chatty thoguh.
@jcsteh
Copy link
Contributor

jcsteh commented Nov 11, 2015

Rather than consuming an extra keystroke, it'd be good if we could have landmarks included in the move past end of container command (comma). This could be a bit tricky, though.

@derekriemer
Copy link
Collaborator

If I want to give this a try, are there any things I should know?

derekriemer pushed a commit to derekriemer/nvda that referenced this issue Oct 17, 2016
In browse mode, it is now possible to skip past landmarks if there is…
51c3632 
… one using the skip to end/beginning of container command. If there is a container inside of a landmark, this command retains the behavior of only skipping to the end of the container. nvaccess#5482

This needs testing in edge, and look over from someone who knows more about browse mode. Also, I'm not sure why there are two methods, one in virtualBuffers/__init__.py and browseMode.py, so if someone can check my code for sanity, that would be great.
derekriemer pushed a commit to derekriemer/nvda that referenced this issue Oct 17, 2016
In browse mode, it is now possible to skip past landmarks if there is…
57e4aad 
… one using the skip to end/beginning of container command. If there is a container inside of a landmark, this command retains the behavior of only skipping to the end of the container. nvaccess#5482

This needs testing in edge, and look over from someone who knows more about browse mode. Also, I'm not sure why there are two methods, one in virtualBuffers/__init__.py and browseMode.py, so if someone can check my code for sanity, that would be great.
jcsteh added a commit that referenced this issue Aug 2, 2017
@jcsteh
In browse mode, it is now possible to skip past landmarks if there is…
058595e 
… one using the skip to end/beginning of container command. Incubates #6474 (issue #5482).
@derekriemer derekriemer mentioned this issue Aug 24, 2017
Merged
@nvaccessAuto nvaccessAuto added this to the 2017.3 milestone Aug 24, 2017
jcsteh pushed a commit that referenced this issue Aug 24, 2017
@jcsteh
In browse mode, it is now possible to skip past/to the start of landm…
0429faa 
…arks using the skip to end/beginning of container commands. (issue #5482, PR #6474)
@jcsteh jcsteh modified the milestones: 2017.4, 2017.3 Aug 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature/browse-mode
Projects
None yet
Milestone
2017.4
Development

No branches or pull requests
4 participants
@jcsteh @derekriemer @sukiletxe @nvaccessAuto