Annotations in browse mode on the web #5691

Closed
jcsteh opened this Issue Jan 19, 2016 · 2 comments

Projects

None yet

4 participants

@jcsteh
Contributor
jcsteh commented Jan 19, 2016

Pressing "a" or shift+a to navigate by annotation says "No next/previous annotation".

  1. In Internet Explorer, this should search for ins/del tags.

  2. In other browsers, it should report "Not supported in this document".

    I think this can be generalised to all quick navigation types that aren't supported by specific VirtualBuffers. I think this can be done by having VirtualBuffer._iterNodesByType raise NotImplementedError instead of returning an empty iterator when a type is not supported.

    On a related note, BrowseModeTreeInterceptor._iterNodesByType needs to document that it can raise NotImplementedError. It should probably also do this itself instead of returning an empty iterator.

Thoughts, @MichaelDCurran?

@leonardder
Contributor

This reminds me of the fact that browse mode in Word says 'not supported' when using e for edit boxes, while there are in fact documents with edit boxes in word.

@nvaccessAuto

Incubated in 777280a.

@jcsteh jcsteh added this to the 2016.2 milestone Feb 1, 2016
@jcsteh jcsteh added a commit that referenced this issue Feb 22, 2016
@michaelDCurran @jcsteh michaelDCurran + jcsteh In browse mode, when attempting to use single letter navigation to mo…
…ve to an element which isn't supported for the document, NVDA reports that this isn't supported rather than reporting that there is no element in that direction.

_iterNodesByType now always raises NotImplementedError when a type is not supported.
Re #5691.
bdcee72
@jcsteh jcsteh added a commit that closed this issue Feb 22, 2016
@michaelDCurran @jcsteh michaelDCurran + jcsteh In browse mode in Internet Explorer and other MSHTML controls, using …
…first letter navigation to move by annotation (a and shift+a) now moves to inserted and deleted text.

Fixes #5691.
30f5bb6
@jcsteh jcsteh closed this in 30f5bb6 Feb 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment