Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keyCommandsDoc: Allow full-width colon for settings with a single key #5739

Closed
jcsteh opened this issue Feb 10, 2016 · 2 comments
Closed

keyCommandsDoc: Allow full-width colon for settings with a single key #5739

jcsteh opened this issue Feb 10, 2016 · 2 comments
Assignees
Milestone

Comments

@jcsteh
Copy link
Contributor

@jcsteh jcsteh commented Feb 10, 2016

When there is a setting with a common key for all layouts, the %kc:setting command expects a line in the form "blah: key". For languages such as Chinese, it is common to use a full-width colon (:) instead of a regular colon (:). We should handle both.

@jcsteh jcsteh self-assigned this Feb 10, 2016
@jcsteh jcsteh added this to the 2016.2 milestone Feb 10, 2016
jcsteh added a commit that referenced this issue Mar 3, 2016
…hich has a common key for all layouts, the key may now be placed after a full-width colon (:) as well as the regular colon (:).

Fixes #5739.
@nvaccessAuto
Copy link

@nvaccessAuto nvaccessAuto commented Mar 3, 2016

Incubated in 539bba5.

jcsteh added a commit that referenced this issue Mar 3, 2016
… the line.

This shouldn't be there, but quite a few translations have this mistake and it's not serious enough to cause a build error.
Re #5739.
@nvaccessAuto
Copy link

@nvaccessAuto nvaccessAuto commented Mar 3, 2016

Incubated in 47b989b.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants