New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keyCommandsDoc: Allow full-width colon for settings with a single key #5739

Closed
jcsteh opened this Issue Feb 10, 2016 · 2 comments

Comments

Projects
None yet
2 participants
@jcsteh
Contributor

jcsteh commented Feb 10, 2016

When there is a setting with a common key for all layouts, the %kc:setting command expects a line in the form "blah: key". For languages such as Chinese, it is common to use a full-width colon (:) instead of a regular colon (:). We should handle both.

@jcsteh jcsteh added the Localisation label Feb 10, 2016

@jcsteh jcsteh self-assigned this Feb 10, 2016

@jcsteh jcsteh added this to the 2016.2 milestone Feb 10, 2016

jcsteh added a commit that referenced this issue Mar 3, 2016

In the User Guide, when a %kc:setting command is used for a setting w…
…hich has a common key for all layouts, the key may now be placed after a full-width colon (:) as well as the regular colon (:).

Fixes #5739.
@nvaccessAuto

This comment has been minimized.

Show comment
Hide comment
@nvaccessAuto

nvaccessAuto commented Mar 3, 2016

Incubated in 539bba5.

jcsteh added a commit that referenced this issue Mar 3, 2016

keyCommandsDoc: Allow a vertical bar (|) symbol in the key portion of…
… the line.

This shouldn't be there, but quite a few translations have this mistake and it's not serious enough to cause a build error.
Re #5739.
@nvaccessAuto

This comment has been minimized.

Show comment
Hide comment
@nvaccessAuto

nvaccessAuto commented Mar 3, 2016

Incubated in 47b989b.

@jcsteh jcsteh closed this in 644972d Mar 31, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment