New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translatable strings in versionInfo never get translated #586

Closed
nvaccessAuto opened this Issue Mar 4, 2010 · 2 comments

Comments

Projects
None yet
2 participants
@nvaccessAuto

nvaccessAuto commented Mar 4, 2010

Reported by jteh on 2010-03-04 06:08
Even though the strings in the versionInfo module are marked as translatable, they always render as English, even when the language is set to something else. This is most obvious in the NVDA About dialog.

I suspect this is caused by versionInfo being imported in logHandler.FileHandler.handle(). Although this is a late import, NVDA does log some messages before initialising languageHandler. This change was introduced in 0863820 and is therefore probably a regression introduced in 2009.1rc1.

Notes:

  • We import versionInfo there to check whether this is a test version.
  • We can't initialise languageHandler earlier because it requires config to be loaded and we want to be able to log NVDA startup and config load.
@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Mar 4, 2010

Comment 1 by jteh on 2010-03-04 06:19
Changes:
Milestone changed from None to 2010.1

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Mar 4, 2010

Comment 2 by jteh on 2010-03-04 07:05
Fixed in 80d9c25.
Changes:
State: closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment