New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When toggling between Native input and Alpha numeric input, braille message is needed #5892

Closed
surfer0627 opened this Issue Apr 20, 2016 · 2 comments

Comments

Projects
None yet
4 participants
@surfer0627
Contributor

surfer0627 commented Apr 20, 2016

This case happen in east-Asian input methods.

Steps to reproduce:

  1. Open text editor.
  2. Press ctrl+space switch to native input.
  3. Press shift
    speech: Alpha numeric input
    braille: nothing
    expected: Alpha numeric input
  4. Press shift again
    speech: Native input
    braille: nothing
    expected: Native input
@josephsl

This comment has been minimized.

Show comment
Hide comment
@josephsl

josephsl Apr 20, 2016

Collaborator

Hi, To @michaelDCurran and @nishimotz: I think Victor is raising an important bug here, one that we haven’t thought about. Thanks.

From: surfer0627 [mailto:notifications@github.com]
Sent: Tuesday, April 19, 2016 6:22 PM
To: nvaccess/nvda
Subject: [nvaccess/nvda] When toggling between Native input and Alpha numeric input, braille message is needed (#5892)

This case happen in east-Asian input methods.

Steps to reproduce:

  1. Open text editor.
  2. Press ctrl+space switch to native input.
  3. Press shift
    speech: Alpha numeric input
    braille: nothing
    expected: Alpha numeric input
  4. Press shift again speech: Native input braille: nothing expected: Native input


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub #5892 Image removed by sender.

Collaborator

josephsl commented Apr 20, 2016

Hi, To @michaelDCurran and @nishimotz: I think Victor is raising an important bug here, one that we haven’t thought about. Thanks.

From: surfer0627 [mailto:notifications@github.com]
Sent: Tuesday, April 19, 2016 6:22 PM
To: nvaccess/nvda
Subject: [nvaccess/nvda] When toggling between Native input and Alpha numeric input, braille message is needed (#5892)

This case happen in east-Asian input methods.

Steps to reproduce:

  1. Open text editor.
  2. Press ctrl+space switch to native input.
  3. Press shift
    speech: Alpha numeric input
    braille: nothing
    expected: Alpha numeric input
  4. Press shift again speech: Native input braille: nothing expected: Native input


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub #5892 Image removed by sender.

@jcsteh

This comment has been minimized.

Show comment
Hide comment
@jcsteh

jcsteh Apr 20, 2016

Contributor

Agreed.

Technical: This is a fairly easy fix: at the bottom of NVDAHelper.handleInputConversionModeUpdate, change the speech.speakMessage call to ui.message. It needs to be tested just to be sure, though.

Contributor

jcsteh commented Apr 20, 2016

Agreed.

Technical: This is a fairly easy fix: at the bottom of NVDAHelper.handleInputConversionModeUpdate, change the speech.speakMessage call to ui.message. It needs to be tested just to be sure, though.

@jcsteh jcsteh closed this in #6232 Sep 16, 2016

@nvaccessAuto nvaccessAuto added this to the 2016.4 milestone Sep 16, 2016

jcsteh added a commit that referenced this issue Sep 16, 2016

Messages are now displayed in braille when changing input modes for a…
…n input method (native input/alphanumeric, full shaped/half shaped, etc.).

PR #6232. Issues #5892, #5893.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment