New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eSpeak NG in NVDA 2016.2 does not honor punctuation levels for som punctuation characters #6037

Closed
mohammadrezarashad opened this Issue Jun 3, 2016 · 6 comments

Comments

Projects
None yet
4 participants
@mohammadrezarashad

mohammadrezarashad commented Jun 3, 2016

when I press NVDA+F12 for "say time", NVDA announced "colon" between numbers; even if I set the punctuation speeking to "none" for example, 13 colon 29. This problem also exists for closed parenthesis ")". Worst of all, when I set punctuation to all, NVDA reads one ) twice.
This problem occurs when I use eSpeak NG in Persian.
Finally, when I open the LogViewer of NVDA 2016.2, I see in line 14 the following:
Using eSpeak version 1.48.15 16.Apr.15
I have same abovementioned problems with eSpeak 1.48.15 on android, too.

@jcsteh

This comment has been minimized.

Show comment
Hide comment
@jcsteh

jcsteh Jun 3, 2016

Contributor

We're definitely using eSpeak NG now, but the version it reports is incorrect. However, I'm guessing it is an earlier commit than the one which fixes the punctuation problem for Persian.

CC @michaelDCurran. Note that @mohammadrezarashad explained elsewhere that the Persian contributor for eSpeak NG has apparently fixed this. So, hopefully we can update safely.

Contributor

jcsteh commented Jun 3, 2016

We're definitely using eSpeak NG now, but the version it reports is incorrect. However, I'm guessing it is an earlier commit than the one which fixes the punctuation problem for Persian.

CC @michaelDCurran. Note that @mohammadrezarashad explained elsewhere that the Persian contributor for eSpeak NG has apparently fixed this. So, hopefully we can update safely.

@jcsteh jcsteh added this to the 2016.3 milestone Jun 3, 2016

@nvaccessAuto nvaccessAuto added the p1 label Jul 5, 2016

@michaelDCurran

This comment has been minimized.

Show comment
Hide comment
@michaelDCurran

michaelDCurran Jul 6, 2016

Contributor

Latest eSpeak-NG master is now in NVDA next. Is the issue fixed when running a Next snapshot?

Contributor

michaelDCurran commented Jul 6, 2016

Latest eSpeak-NG master is now in NVDA next. Is the issue fixed when running a Next snapshot?

@mohammadrezarashad

This comment has been minimized.

Show comment
Hide comment
@mohammadrezarashad

mohammadrezarashad Jul 7, 2016

Hello dear friends,
The issue fixed successfully.
thanks
Mohammadreza

۱۳۹۵-۰۴-۱۷ ۳:۳۷ +۰۴:۳۰ گرینویچ, Michael Curran notifications@github.com:

Latest eSpeak-NG master is now in NVDA next. Is the issue fixed when running
a Next snapshot?


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#6037 (comment)

mohammadrezarashad commented Jul 7, 2016

Hello dear friends,
The issue fixed successfully.
thanks
Mohammadreza

۱۳۹۵-۰۴-۱۷ ۳:۳۷ +۰۴:۳۰ گرینویچ, Michael Curran notifications@github.com:

Latest eSpeak-NG master is now in NVDA next. Is the issue fixed when running
a Next snapshot?


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#6037 (comment)

michaelDCurran added a commit that referenced this issue Jul 8, 2016

revert #6037
Not suppressing wx assertions causes them to be raised as exceptions in random places. Rather we'll want to log them instead.
@mohammadrezarashad

This comment has been minimized.

Show comment
Hide comment
@mohammadrezarashad

mohammadrezarashad Jul 13, 2016

Warning!:
Unfortunately, faulty eSpeak is now in NVDA snapshots again. Although the problem for eSpeak in Persian was fixed in next13392; but again falls back in master13414 and master13420.

mohammadrezarashad commented Jul 13, 2016

Warning!:
Unfortunately, faulty eSpeak is now in NVDA snapshots again. Although the problem for eSpeak in Persian was fixed in next13392; but again falls back in master13414 and master13420.

@michaelDCurran

This comment has been minimized.

Show comment
Hide comment
@michaelDCurran

michaelDCurran Jul 14, 2016

Contributor

The upgrade to latest eSpeakNG master has not made its way from NVDA
Next to NVDA master yet.

This should happen in a week or so.

Thanks

Mick

On 14/07/2016 4:04 AM, mohammadrezarashad wrote:

Warning!:
Unfortunately, faulty eSpeak is now in NVDA snapshots again. Although
the problem for eSpeak in Persian was fixed in next13392; but again
falls back in master13414 and master13420.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#6037 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ANf5nfamBdAJNZHHBAEbsAQTvIEh8S4Wks5qVSiqgaJpZM4ItWSa.

Michael Curran
Executive Director, NV Access Limited
Phone: +61 7 3149 3306
Website: http://www.nvaccess.org/
Twitter: @nvaccess
Facebook: http://www.facebook.com/NVAccess

Contributor

michaelDCurran commented Jul 14, 2016

The upgrade to latest eSpeakNG master has not made its way from NVDA
Next to NVDA master yet.

This should happen in a week or so.

Thanks

Mick

On 14/07/2016 4:04 AM, mohammadrezarashad wrote:

Warning!:
Unfortunately, faulty eSpeak is now in NVDA snapshots again. Although
the problem for eSpeak in Persian was fixed in next13392; but again
falls back in master13414 and master13420.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#6037 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ANf5nfamBdAJNZHHBAEbsAQTvIEh8S4Wks5qVSiqgaJpZM4ItWSa.

Michael Curran
Executive Director, NV Access Limited
Phone: +61 7 3149 3306
Website: http://www.nvaccess.org/
Twitter: @nvaccess
Facebook: http://www.facebook.com/NVAccess

@mohammadrezarashad

This comment has been minimized.

Show comment
Hide comment
@mohammadrezarashad

mohammadrezarashad Jul 25, 2016

Thanks so much!
Good Luck!
Mohammadreza

۱۳۹۵-۰۵-۰۴ ۲:۳۳ +۰۴:۳۰ گرینویچ, Michael Curran notifications@github.com:

Closed #6037 via #6147.


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#6037 (comment)

mohammadrezarashad commented Jul 25, 2016

Thanks so much!
Good Luck!
Mohammadreza

۱۳۹۵-۰۵-۰۴ ۲:۳۳ +۰۴:۳۰ گرینویچ, Michael Curran notifications@github.com:

Closed #6037 via #6147.


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#6037 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment