Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

speech.speakObject should output to Speech Viewer when speech mode is off #6049

Closed
jcsteh opened this issue Jun 8, 2016 · 0 comments
Closed

speech.speakObject should output to Speech Viewer when speech mode is off #6049

jcsteh opened this issue Jun 8, 2016 · 0 comments
Labels
p3 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority
Milestone
2016.3

Comments

@jcsteh
Copy link
Contributor

jcsteh commented Jun 8, 2016

STR:

  1. Enable Speech Viewer.
  2. Press NVDA+s until NVDA says "speech mode off".
  3. Press NVDA+tab to report the focus.
    • Expected: Info about the focus in the Speech Viewer.
    • Actual: Nothing in the Speech Viewer.

speech.speakObject optimises by returning early if speech mode is off. It should check if Speech Viewer is active as well.
@nvaccessAuto nvaccessAuto added the p3 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority label Jul 5, 2016
feerrenrut added a commit that referenced this issue Jul 19, 2016
@feerrenrut
Dont filter output when speech mode is off
ee47ea8 
Fixes #6049
@feerrenrut feerrenrut mentioned this issue Jul 19, 2016
Merged
feerrenrut added a commit that referenced this issue Jul 25, 2016
@feerrenrut
incubates #6193
9337c4d 
Issue: #6049
Merge branch 'i6049-ShowAllSpeechInSpeechViewer' into next
jcsteh pushed a commit that referenced this issue Aug 8, 2016
@feerrenrut @jcsteh
When speech mode is off, reporting objects (such as pressing NVDA+tab…
e7dbeb1 
… to report the focus) now appears in the Speech Viewer as expected. (#6049)
@jcsteh jcsteh added this to the 2016.3 milestone Aug 8, 2016
jcsteh added a commit that referenced this issue Aug 8, 2016
@jcsteh
Update What's New for #5941, #6049.
5d37563
@feerrenrut feerrenrut removed their assignment Aug 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p3 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority
Projects
None yet
Milestone
2016.3
Development

No branches or pull requests
3 participants
@feerrenrut @jcsteh @nvaccessAuto