New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken Google Chrome support from NVDA #6249

Closed
dreinn opened this Issue Aug 8, 2016 · 3 comments

Comments

Projects
None yet
2 participants
@dreinn

dreinn commented Aug 8, 2016

Google Chrome is quite unusable now with NVDA.
I'm using version 52, with NVDA snapshot next-13418,a6c0724c.
When you press h for moving between headings, or press downarrow key, in many website NVDA make the error tone and don't read text, links, etc.
an example?
www.yahoo.it

I attach the log, anyway the error regards bad mxl formatting.
Can you fix please?

chrome.txt

@jcsteh jcsteh added the GoogleWork label Aug 23, 2016

@jcsteh

This comment has been minimized.

Show comment
Hide comment
@jcsteh

jcsteh Aug 23, 2016

Contributor

This works when Chrome is set to use English, but breaks for Italian and possibly other languages. This needs to be fixed in Chrome, so I've filed Chromium issue 640043. I'm going to see if I can at least partially work around this in NVDA.

Contributor

jcsteh commented Aug 23, 2016

This works when Chrome is set to use English, but breaks for Italian and possibly other languages. This needs to be fixed in Chrome, so I've filed Chromium issue 640043. I'm going to see if I can at least partially work around this in NVDA.

jcsteh added a commit that referenced this issue Aug 23, 2016

In Google Chrome and Chrome-based browsers in a language other than E…
…nglish, browse mode no longer fails to work in many documents. (#6249)

Chrome incorrectly localises the name returned by IAccessibleAction::name, but this means it contains a space for some actions in some languages; e.g. "click" is "fai clic" in Italian. This results in the buffer producing an invalid XML attribute name, which breaks reading of affected content. We now filter the XML so this doesn't happen.

@jcsteh jcsteh closed this in #6295 Aug 23, 2016

jcsteh added a commit that referenced this issue Aug 23, 2016

In Google Chrome and Chrome-based browsers in a language other than E…
…nglish, browse mode no longer fails to work in many documents.

Chrome incorrectly localises the name returned by IAccessibleAction::name, but this means it contains a space for some actions in some languages; e.g. "click" is "fai clic" in Italian. This results in the buffer producing an invalid XML attribute name, which breaks reading of affected content. We now filter the XML so this doesn't happen.

Issue #6249. PR #6295.

@jcsteh jcsteh added this to the 2016.3 milestone Aug 23, 2016

@jcsteh

This comment has been minimized.

Show comment
Hide comment
@jcsteh

jcsteh Aug 23, 2016

Contributor

I've worked around this as far as we can in NVDA. You won't get told about clickable content--that needs to be fixed in Chrome--but NVDA no longer chokes completely. I've pushed this as a very late fix into 2016.3 because it's pretty nasty.

Contributor

jcsteh commented Aug 23, 2016

I've worked around this as far as we can in NVDA. You won't get told about clickable content--that needs to be fixed in Chrome--but NVDA no longer chokes completely. I've pushed this as a very late fix into 2016.3 because it's pretty nasty.

@dreinn

This comment has been minimized.

Show comment
Hide comment
@dreinn

dreinn Aug 23, 2016

Thank you very much Jamie, in fact I have this problem on 3 different pc
and I was quite surprise that nobody on NVDA mailing list report this.
Really thank you.

Il 23/08/2016 06:39, James Teh ha scritto:

I've worked around this as far as we can in NVDA. You won't get told
about clickable content--that needs to be fixed in Chrome--but NVDA no
longer chokes completely. I've pushed this as a very late fix into
2016.3 because it's pretty nasty.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#6249 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/APp_GDQ8MYpCndFymwQ1cGd6coK4D3Tzks5qinlpgaJpZM4Jey7q.

dreinn commented Aug 23, 2016

Thank you very much Jamie, in fact I have this problem on 3 different pc
and I was quite surprise that nobody on NVDA mailing list report this.
Really thank you.

Il 23/08/2016 06:39, James Teh ha scritto:

I've worked around this as far as we can in NVDA. You won't get told
about clickable content--that needs to be fixed in Chrome--but NVDA no
longer chokes completely. I've pushed this as a very late fix into
2016.3 because it's pretty nasty.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#6249 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/APp_GDQ8MYpCndFymwQ1cGd6coK4D3Tzks5qinlpgaJpZM4Jey7q.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment