Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using the mouse in the symbol pronunciation list does not work well #6312

Closed
feerrenrut opened this issue Aug 29, 2016 · 0 comments · Fixed by #6328
Closed

Using the mouse in the symbol pronunciation list does not work well #6312

feerrenrut opened this issue Aug 29, 2016 · 0 comments · Fixed by #6328
Assignees
Milestone

Comments

@feerrenrut
Copy link
Contributor

Case 1:
Add a new symbol, eg 'test'
Click in the replacement edit field (notice that there is no cursor)
Try typing (notice that the field receives no text)

Clicking in the replacement edit field should result in a cursor, and it should receive text.

Case 2:
Select 'test' from the symbol list
Press alt+r to focus the replacement edit field (notice that there is no cursor)
Try typing (text IS received)
Click in the symbol list (notice that the 'test' field is not updated)

Using the mouse to remove focus from the replacement edit field should result in the symbol item being updated.

These issues make the dialog difficult to use with a mouse.

@feerrenrut feerrenrut self-assigned this Aug 29, 2016
feerrenrut added a commit that referenced this issue Sep 2, 2016
Updating the symbol list items as the "change symbol" fields are
changed fixes an issue where the values for the items in the list were
not updated when the mouse was used to select a new item in the list.
When the already selected (and now changed) item was reselected, then
the item in the list WAS updated.
This issue seemed to be caused by the EVT_KILL_FOCUS and the
EVT_LIST_ITEM_FOCUSED being received out of order.

Disables "change symbol" fields when no item is selected (when dialog is
first opened. Seeing the fields disabled helps to indicate that an item
must be selected first. When this happens its clear that the fields
relate to the selected item, as they can be seen to update.

Fixes #6312
feerrenrut added a commit that referenced this issue Sep 5, 2016
re #6312
Merge branch 'i6312-FixMouseInteractionSymbolList' into next
@nvaccessAuto nvaccessAuto modified the milestone: 2016.4 Sep 19, 2016
feerrenrut added a commit that referenced this issue Sep 19, 2016
Fixes #6312 
PR: #6328

The mouse can now be used more effectively in the symbol pronunciation dialog.

Updating the symbol list items as the "change symbol" fields are
changed fixes an issue where the values for the items in the list were
not updated when the mouse was used to select a new item in the list.
When the already selected (and now changed) item was reselected, then
the item in the list WAS updated.
This issue seemed to be caused by the EVT_KILL_FOCUS and the
EVT_LIST_ITEM_FOCUSED being received out of order.

The "change symbol" fields are now disabled when no item is selected (when dialog is
first opened). Seeing the fields disabled helps to indicate that an item
must be selected first. When this happens its clear that the fields
relate to the selected item, as they can be seen to update.
feerrenrut added a commit that referenced this issue Sep 19, 2016
The mouse can now be used to move focus between the symbol list and the edit fields in the symbol pronunciation dialog. (#6312)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants