New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added the possibility to create a portable copy with the use of command line parameters #6329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can you give a real world use case/scenario for this? Unattended installation is useful for a complete unattended system install or a deployment across multiple machines, but portable copies are usually something a particular user would choose to generate for their use, rather than something you would deploy during a system install or across multiple systems. Thanks.
|
Sure:
|
…nd line parameters (nvaccess#6281: * --create-portable: creates a new portable copy and starts it after creation * --create-portable-silent: creates a new portable copy and shuts down NVDA Both parameters depend on the --portable-path parameter, which has to contain the path to the new portable copy. IN the process, added a new checkbox to the create portable copy dialog which allows for starting the new copy after installation.
feerrenrut
approved these changes
Aug 30, 2017
Sorry @feerrenrut, realised that command line parameters should be added to the user guide. |
feerrenrut
suggested changes
Sep 4, 2017
user_docs/en/userGuide.t2t
Outdated
@@ -2471,6 +2471,9 @@ Following are the command line options for NVDA: | |||
| None | --no-sr-flag | Don't change the global system screen reader flag | | |||
| None | --install | Installs NVDA (starting the newly installed copy) | | |||
| None | --install-silent | Silently installs NVDA (does not start the newly installed copy) | | |||
| None | --create-portable | Creates a portable copy of NVDA (starting the newly created copy) | | |||
| None | --create-portable-silent | Creates a portable copy of NVDA (does not start the newly installed copy) | | |||
| None | portable-path=PORTABLEPATH | The path where a portable copy will be created | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this argument start with --
?
Also could you document the dependencies between the arguments?
…ent depend on --portable-path for real this time
feerrenrut
approved these changes
Sep 11, 2017
feerrenrut
added a commit
that referenced
this pull request
Sep 11, 2017
feerrenrut
added a commit
that referenced
this pull request
Oct 2, 2017
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both parameters depend on the --portable-path parameter, which has to contain the path to the new portable copy.
IN the process, added a new checkbox to the create portable copy dialog which allows for starting the new copy after installation.