New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align ok and cancel buttons to the right #6333

Closed
feerrenrut opened this Issue Sep 5, 2016 · 1 comment

Comments

Projects
None yet
2 participants
@feerrenrut
Contributor

feerrenrut commented Sep 5, 2016

Typically in windows the ok / cancel buttons are on the right of the dialog. While I dont think this matters a great deal, its nice to be consistent. I think it also helps to show that the buttons relate to the dialog rather than being part of the dialog content.

When implementing this in #6189 I found that the buttons didn't cope with the resizable dialog very well when aligned to the right, this may be a limitation of the wx framework.
Try putting the buttons in a panel first, see http://zetcode.com/gui/wxwidgets/layoutmanagement/

@feerrenrut

This comment has been minimized.

Show comment
Hide comment
@feerrenrut

feerrenrut Sep 6, 2016

Contributor

Feedback on GUI, received via email.

The OK/Cancel buttons are nicely spaced between each other and padded well from the left and bottom edge of the dialog, but they are very close to the other options on the dialog. they need to be moved down a bit away from the options above them. They should also be right-aligned on the dialog. It is correct to have OK to the left of Cancel, but in layout terms, most dialogs in Windows have these two buttons right-aligned in the dialog overall (still padded from the edge of the dialog but certainly right aligned).

This spacing issue might appear on other dialogs as well. I will comment as appropriate when/if it comes up.

Contributor

feerrenrut commented Sep 6, 2016

Feedback on GUI, received via email.

The OK/Cancel buttons are nicely spaced between each other and padded well from the left and bottom edge of the dialog, but they are very close to the other options on the dialog. they need to be moved down a bit away from the options above them. They should also be right-aligned on the dialog. It is correct to have OK to the left of Cancel, but in layout terms, most dialogs in Windows have these two buttons right-aligned in the dialog overall (still padded from the edge of the dialog but certainly right aligned).

This spacing issue might appear on other dialogs as well. I will comment as appropriate when/if it comes up.

feerrenrut added a commit that referenced this issue Oct 4, 2016

@feerrenrut feerrenrut self-assigned this Oct 4, 2016

feerrenrut added a commit that referenced this issue Oct 12, 2016

incubates #6426
Fixes issue #6333
Merge branch 'i6333_alignOkCancel' into next

Conflicts:
	source/gui/guiHelper.py
	source/gui/settingsDialogs.py
	user_docs/en/userGuide.t2t

feerrenrut added a commit that referenced this issue Oct 27, 2016

Align ok and cancel buttons to right (PR #6426)
fixes #6333

Align 'ok' and 'cancel' buttons to the right of dialog boxes.

feerrenrut added a commit that referenced this issue Oct 27, 2016

Update changes file for PR #6426
NVDA dialog boxes now have their "ok" and "cancel" buttons aligned to the right of the dialog. (Issue #6333)

@nvaccessAuto nvaccessAuto added this to the 2016.4 milestone Oct 27, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment