Enable and disable add-ons with keyboard accelerators

[LeonarddeR]

I noticed that, in the add-ons gui, the accelerators were missing for enabling and disabling add-ons. I added them in this pr, since it makes it much easier to walk through the add-ons list, enabling and disabling add-ons on the fly with the corresponding accelerators. I didn't use the same accelerator for enabling and disabling due to two reasons:

1. There is no logical letter to use for both enabling and disabling, so the accelerator would be a non-obvious one
2. You will always be sure what the corresponding accelerator (either e or d) does.

[jcsteh]

Looks good. Thanks!

[derekriemer]

Hi:

Joseph actually didn't put this in because he thought it made a good UI
statement, which is that a user should only disable an add-on while
doing something purposeful while disabling an add-on, but I tend to
disagree with him on this point. I thought I'd point it out
nevertheless, since the question had been brought up before.

On 9/19/2016 2:55 AM, Leonard de Ruijter wrote:

I noticed that, in the add-ons gui, the accelerators were missing for
enabling and disabling add-ons. I added them in this pr, since it
makes it much easier to walk through the add-ons list, enabling and
disabling add-ons on the fly with the corresponding accelerators. I
didn't use the same accelerator for enabling and disabling due to two
reasons:

1. There is no logical letter to use for both enabling and disabling,
   so the accelerator would be a non-obvious one
2. You will always be sure what the corresponding accelerator (either
   e or d) does.

---

    You can view, comment on, or merge this pull request online at:

#6388

    Commit Summary

• It is now possible to enable and disable add-ons from the add-ons
  list using keyboard accelerators alt+e and alt+d respectively

  File Changes
  

• M source/gui/addonGui.py
  https://github.com/nvaccess/nvda/pull/6388/files#diff-0 (8)

  Patch Links:
  

• https://github.com/nvaccess/nvda/pull/6388.patch

• https://github.com/nvaccess/nvda/pull/6388.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#6388, or mute the thread
https://github.com/notifications/unsubscribe-auth/AFGivVXG0b_XNv573qhtypECZrASQiEnks5qrk3_gaJpZM4KAQy9.

---

Derek Riemer

• Department of computer science, third year undergraduate student.
• Proud user of the NVDA screen reader.
• Open source enthusiast.
• Member of Bridge Cu
• Avid skiier.

Websites:
Honors portfolio http://derekriemer.com
Awesome little hand built weather app!
http://django.derekriemer.com/weather/

email me at derek.riemer@colorado.edu mailto:derek.riemer@colorado.edu
Phone: (303) 906-2194