New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restart confirmation dialog is confusing #6416
Comments
As the only focusable controls in the dialog are both buttons, pressing I am happy with Restart Now / Restart Later buttons. |
P3 because this is low impact. |
@feerrenrut It sounds like resolving this issue simply requires the message in the dialog and the button names to be modified. If this is indeed the case, may we label this ticket as a QuickFix and GoodForNewDevs or something? If not, excuse my misinterpretation. |
While creating PR: #6415 to fix issue: #4561 I found that the restart confirmation dialog is confusing. My immediate expectation was that pressing cancel would make no changes and I would return to the general settings dialog. However the actual behaviour (as explained in the text) is that pressing cancel meant the general settings dialog would close, and the language change will be applied after the next restart of nvda. This dialog requires careful reading of the dialog in order to understand the outcomes.
The current text is:
With
ok
andcancel
buttons.Perhaps instead:
With
restart now
andrestart later
buttonsOne issue with this is that for non-sighted users its not so clear what pressing enter will do, is this a valid concern here?
The text was updated successfully, but these errors were encountered: