Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restart confirmation dialog is confusing #6416

Closed
feerrenrut opened this Issue Sep 30, 2016 · 3 comments

Comments

Projects
None yet
5 participants
@feerrenrut
Copy link
Contributor

feerrenrut commented Sep 30, 2016

While creating PR: #6415 to fix issue: #4561 I found that the restart confirmation dialog is confusing. My immediate expectation was that pressing cancel would make no changes and I would return to the general settings dialog. However the actual behaviour (as explained in the text) is that pressing cancel meant the general settings dialog would close, and the language change will be applied after the next restart of nvda. This dialog requires careful reading of the dialog in order to understand the outcomes.

The current text is:

For the new language to take effect, the configuration must be saved and NVDA must be restarted. Press enter to save and restart NVDA, or cancel to manually save and exit at a later time.

With ok and cancel buttons.

Perhaps instead:

NVDA must be restarted for the new language to take effect.

With restart now and restart later buttons

One issue with this is that for non-sighted users its not so clear what pressing enter will do, is this a valid concern here?

@feerrenrut feerrenrut added the NVDA GUI label Sep 30, 2016

@michaelDCurran

This comment has been minimized.

Copy link
Contributor

michaelDCurran commented Oct 3, 2016

As the only focusable controls in the dialog are both buttons, pressing
enter will activate the button currently focused. (Enter does not seem
to resort to default behaviour on a button).

I am happy with Restart Now / Restart Later buttons.

@jcsteh jcsteh added the p3 label Oct 7, 2016

@jcsteh

This comment has been minimized.

Copy link
Contributor

jcsteh commented Oct 7, 2016

P3 because this is low impact.

@bhavyashah

This comment has been minimized.

Copy link

bhavyashah commented Aug 29, 2017

@feerrenrut It sounds like resolving this issue simply requires the message in the dialog and the button names to be modified. If this is indeed the case, may we label this ticket as a QuickFix and GoodForNewDevs or something? If not, excuse my misinterpretation.

Andre9642 added a commit to Andre9642/nvda that referenced this issue Jul 22, 2018

Andre9642 added a commit to Andre9642/nvda that referenced this issue Jul 23, 2018

Andre9642 added a commit to Andre9642/nvda that referenced this issue Jul 31, 2018

Andre9642 added a commit to Andre9642/nvda that referenced this issue Aug 5, 2018

@nvaccessAuto nvaccessAuto added this to the 2018.4 milestone Dec 7, 2018

feerrenrut added a commit that referenced this issue Dec 7, 2018

Improve restart confirmation dialog after changing interface language…
… (PR #8537)

Fixes for #6416

Improve restart confirmation dialog after changing interface language
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.