Beep if typing lowercase letters when caps lock is on #663

Closed
nvaccessAuto opened this Issue May 21, 2010 · 9 comments

2 participants

@nvaccessAuto

Reported by tspivey on 2010-05-21 11:49
When typing with key echo off, it's not that easy to tel whether caps lock has accidentally been activated unless you backspace. Some speech systems have a feature where they will beep if you type a shifted letter with caps lock enabled (which generates a lowercase letter). I think this feature would help avoid cases of typing entire sentences and paragraphs in caps, without realizing.

@nvaccessAuto

Comment 1 by jeronimo on 2010-05-21 13:38
Changes:
Milestone changed from None to 2010.2

@nvaccessAuto

Comment 2 by jteh on 2010-05-23 00:32
Changes:
Milestone changed from 2010.2 to 2010.3

@nvaccessAuto

Attachment Ticket#663.patch added by acrodelon on 2010-10-28 07:08
Description:
Patch file added to solve the ticket

@nvaccessAuto

Comment 5 by aleksey_s on 2010-11-08 16:20
I can't download your attachment, may be it was screwed somehow. Could you please attach it again, naming file 'ticket663.patch' exactly?
Thanks.

@nvaccessAuto

Attachment Ticket663.patch added by acrodelon on 2010-11-09 05:20
Description:
new patch file is attached

@nvaccessAuto

Comment 6 by aleksey_s on 2010-11-16 08:05
I have reviewed this one.
If core developers are not against the idea, we can apply this.
notes about the code:

  • I prefer if statement that in beepCapitals to be outside of the function. Check config in event_typedCharacter to avoid unnecessary function call.
  • You should use boolean type for capsOn variable, shortening code like this:
    capsOn=state in [-127](1,)
    if capsOn and ch.islower():
...

I personally am not sure about whether this option will be widely used. User already has a great choice of options to indicate capitals (speak "capital", raise pitch, beep for capitals), and if even one of that is selected, this option becomes redundant. Anyway, this is only my IMHO, let's see what core developers think.

@nvaccessAuto

Comment 7 by aleksey_s on 2010-11-16 08:11
Oh sorry, I've forgotten to add:

  • You'd better not to use state in [...] but directly check the bit with bitmask (as it is done in other NVDA code which works with getKeyboardState):
capsOn=winUser.getKeyState(winUser.VK_CAPITAL)&1
@nvaccessAuto

Comment 9 by mdcurran on 2010-12-02 00:34
committed in 82d91d8, with a few small changes, see the commit for details.
Changes:
State: closed

@nvaccessAuto

Comment 10 by jteh on 2010-12-02 00:44
This option needs to be added to the User Guide as well.

@nvaccessAuto nvaccessAuto added this to the 2011.1 milestone Nov 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment