Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regular expression hotkey conflict in add dictionary entry dialog #6782

Closed
Qchristensen opened this Issue Jan 23, 2017 · 5 comments

Comments

Projects
None yet
5 participants
@Qchristensen
Copy link

Qchristensen commented Jan 23, 2017

When adding a dictionary entry (NVDA+N, P, D, then enter, then alt+a or select an entry and alt+e)

The replacement field can be accessed directly by pressing alt+r.

The regular expression field has "r" underlined, however, alt+r only goes to replacement.

Also in the add dictionary entry dialog, the underlines only appear visually when alt is pressed. In the edit dictionary entry field, the appropriate letters are underlined all the time.

Both very minor issues.

@josephsl

This comment has been minimized.

Copy link
Collaborator

josephsl commented Jan 23, 2017

@jcsteh

This comment has been minimized.

Copy link
Contributor

jcsteh commented Jan 23, 2017

@Qchristensen

This comment has been minimized.

Copy link
Author

Qchristensen commented Jan 23, 2017

@ehollig

This comment has been minimized.

Copy link
Collaborator

ehollig commented Oct 11, 2017

@Qchristensen, can you confirm whether the second issue still exists for you? Seems okay with the latest Master.
@Qchristensen commented:

Also in the add dictionary entry dialog, the underlines only appear visually when alt is pressed. In the edit dictionary entry field, the appropriate letters are underlined all the time.

Do we agree on the pneumonic for Regular expression to be "E"? (For the "E" in expression)

@Qchristensen

This comment has been minimized.

Copy link
Author

Qchristensen commented Oct 12, 2017

With 2017.3 at least, the underline issue seems resolved. Re the pneumonic, I'm happy with "E".

ehollig added a commit to ehollig/nvda that referenced this issue Oct 12, 2017

ehollig added a commit to ehollig/nvda that referenced this issue Oct 12, 2017

@nvaccessAuto nvaccessAuto added this to the 2017.4 milestone Oct 31, 2017

feerrenrut added a commit that referenced this issue Oct 31, 2017

feerrenrut added a commit that referenced this issue Oct 31, 2017

Update changes file for PR #7656
The hotkey for the regular expression radio button in the dictionary
dialog is changed from alt+r to alt+e (issue #6782)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.