Replace execInWindow with execInThread #6885
Conversation
…sed in a text box in Mozilla applications." This changes execInWindow to again use PostMessage rather than SendMessageCallback. This reverts commit 657fb56.
… PostThreadMessage rather than PostMessage. This still allows us to execute code in a thread via the message queue (avoiding Gecko E10s issues with SendMessage) but also still fixes #6422 as the message will still be received even if the window is destroied.
michaelDCurran
added
the
p3
nvdaHelper/remote/inProcess.cpp
Outdated
| // Wait in a message loop until the callback fires and sends WM_QUIT. | ||
| // We also abort the loop if WaitMessage fails for some reason. | ||
| while (GetMessage(&msg, NULL, WM_QUIT, WM_QUIT) > 0); | ||
| bool execInThread(long threadID, execInThread_funcType func) { |
There was a problem hiding this comment.
Please add a comment here explaining why we are using this approach instead of SendMessage, since SendMessage does seem more intuitive. It should explain the outgoing cross-process COM call failure and the fact that PostMessage avoids re-entrance (which the code can't handle).
nvdaHelper/remote/inProcess.cpp
Outdated
| CloseHandle(handles[1]); | ||
| return false; | ||
| } | ||
| if(WaitForMultipleObjects(2,handles,false,INFINITE)!=WAIT_OBJECT_0) { |
There was a problem hiding this comment.
Would it be useful to know specifically that the thread died while waiting (WAIT_OBJECT_0 + 1) as opposed to some other error? Not sure, but thought I'd raise it as food for thought.
|
Mozilla bug 1342456 got filed concerning crashes in inProcess_winEventCallback like this one. My memory is a bit vague, but I assume this PR should fix those? (This crash was in a build without this fix.) I just want to comment on the bug accordingly. |
Replace nvdaHelperRemote's execInWindow with execInThread, which uses PostThreadMessage rather than PostMessage.
This still allows us to execute code in a thread via the message queue (avoiding Gecko E10s issues with SendMessage) but also still fixes #6422 as the message will still be received even if the window is destroyed.