New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In the properties dialog for a folder, the "not checked" state for the "read-only" attribute is not reported at change #6946

Closed
k-kolev1985 opened this Issue Mar 8, 2017 · 4 comments

Comments

Projects
None yet
5 participants
@k-kolev1985

k-kolev1985 commented Mar 8, 2017

Steps to reproduce it:

  1. Open Windows Explorer.
  2. Select a folder with some files in it. Maybe some of them should be with a read-only attribute and some - not, but I'm not sure that it is required for reproducing the bug.
  3. Press Alt+Enter to invoke the properties dialog for the folder.
  4. Move the focus to the check box for changing the read-only attribute.
  5. Press space a few times to change its status between checked, half-checked and not checked.

Expected results:
NVDA should report all status changes for the check box.

Actual results:
NVDA stays silent when the state of the check box is changed to "not checked".

Note: In order to reproduce this, the check box in question has to have 3 states: checked, half-checked and not checked. If it has only 2 (checked and not checked), NVDA will report both states as it should.

Test environment:

  • Operating system: Windows 10 Pro (build 14393.693), 64-bit, in Bulgarian with all locale settings set to "Bulgarian".
  • NVDA version: next-13899,af44c1d4.
  • Processor: Intel Core i5-2320 at 3.00GHz.
  • RAM Memory: 8.00GB.
  • Graphics: Palit GeForce GT 630, 1024MB dedicated memory + 3071MB shared system memory, desktop resolution set to 1920x1080.
  • Sound Card: Realtek ALC662 at Intel Cougar Point PCH - High Definition Audio Controller.
@feerrenrut

This comment has been minimized.

Show comment
Hide comment
@feerrenrut

feerrenrut Mar 10, 2017

Contributor

Thanks for raising this, and for providing so much information! I can reproduce this with next-13899,af44c1d4.

Assuming this is a quick fix, I will assign this a priority 2.

Contributor

feerrenrut commented Mar 10, 2017

Thanks for raising this, and for providing so much information! I can reproduce this with next-13899,af44c1d4.

Assuming this is a quick fix, I will assign this a priority 2.

@jcsteh

This comment has been minimized.

Show comment
Hide comment
@jcsteh

jcsteh Mar 10, 2017

Contributor

Really quick way to repro this:

  1. Open this URL in Firefox: data:text/html,<div tabindex="0" role="checkbox" aria-checked="mixed" onClick="this.setAttribute('aria-checked', 'false')">Test</div>
  2. Press enter on the check box in browse mode.
  • Expected: "not checked"
  • Actual: Nothing.

Implementation hint: this needs a tweak to speech.processNegativeStates. For REASON_CHANGE, if HALFCHECKED is present but CHECKED isn't, we should make sure we add CHECKED to speakNegatives.

Contributor

jcsteh commented Mar 10, 2017

Really quick way to repro this:

  1. Open this URL in Firefox: data:text/html,<div tabindex="0" role="checkbox" aria-checked="mixed" onClick="this.setAttribute('aria-checked', 'false')">Test</div>
  2. Press enter on the check box in browse mode.
  • Expected: "not checked"
  • Actual: Nothing.

Implementation hint: this needs a tweak to speech.processNegativeStates. For REASON_CHANGE, if HALFCHECKED is present but CHECKED isn't, we should make sure we add CHECKED to speakNegatives.

@derekriemer

This comment has been minimized.

Show comment
Hide comment
@derekriemer

derekriemer Jul 16, 2017

Collaborator

@feerrenrut This seems prime for a goodForNewDev label, no?

Collaborator

derekriemer commented Jul 16, 2017

@feerrenrut This seems prime for a goodForNewDev label, no?

@feerrenrut

This comment has been minimized.

Show comment
Hide comment
@feerrenrut

feerrenrut Jul 17, 2017

Contributor

@derekriemer yeah I think so.

Contributor

feerrenrut commented Jul 17, 2017

@derekriemer yeah I think so.

Andre9642 added a commit to Andre9642/nvda that referenced this issue Jul 24, 2018

@nvaccessAuto nvaccessAuto added this to the 2018.3 milestone Jul 26, 2018

michaelDCurran added a commit that referenced this issue Jul 26, 2018

Fix a case where the "not checked" state is not reported in speech (#…
…8550)

* Add CHECKED to speakNegatives if HALFCHECKED is present but CHECKED isn't for REASON_CHANGE
Fixes #6946

* Change the condition to match the condition originally proposed

* Update What's new
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment