-
-
Notifications
You must be signed in to change notification settings - Fork 626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change multiple settings dialogs into one category based dialog #7302
Conversation
I have had a look at this, I think that a tree view for the categories would make more sense than a list view, even if there is no hierarchy. At the moment the size of the dialog changes with each category. I think we should address this, visually this is a bit jarring. This could be an "interesting" problem to solve. I would suggest that we remove the preferences submenu from the NVDA menu, making it a button that launches the dialog.
Would it be acceptable to change the window title to achieve this? |
@feerrenrut commented on 4 Jul 2017, 17:15 GMT+10:
I assume you mean a menu item rather than a dialog, but yes, I agree. The problem, though, is that this breaks existing shortcuts to quickly get to specific sections; e.g. NVDA+n, p, r for Braille Settings. As non-standard as it might be, I think overriding the default keyboard handling for the tree view may well be preferable to losing these shortcuts. Discoverability remains an open question, though.
Do we actually need to do this? What do similar dialogs in other apps do to show the title of the active page (if anything)?
Perhaps, though I think it should be prefixed; e.g. "Preferences: Braille". Out of interest, I just checked foobar2000 and it does this. |
@jcsteh commented on 4 jul. 2017 13:29 CEST:
So this means speech dictionaries, input gestures, etc. should also go into this dialog? |
@leonardder commented on 5 Jul 2017, 02:36 GMT+10:
Blerg. No, I don't think that makes sense actually. If we were starting from scratch, I'd probably have a Preferences menu containing a Settings... item (this dialog) and the rest of the items as they are (Speech dictionaries, etc.). The problem is that this definitely breaks those well-known shortcuts. I guess the only way to get around this is to somehow alter the way key presses are handled in the NVDA menu. Yuck. |
@jcsteh commented on 5 jul. 2017 00:50 CEST:
If the same order/sequence of key presses is that important to you, I guess we only have two options left. Drop this whole idea and pr altogether, or create a preferences... menu item and make the tree view react properly to the given key presses. |
I assume you mean a menu item rather than a dialog
No, I don't think so. However we might be talking about the same thing. I
was suggesting that when a user presses `NVDA+n` then `p` the new
preferences window is opened (presumably on the general tab) with focus set
to the tree view which lists the actual settings pages. Essentially the
'preferences' item in the NVDA menu acts as a button rather than a sub-menu.
Perhaps breaking the keyboard shortcuts IS the best option. This is a major
change to UX after all, perhaps this is the best time to break keyboard
shortcuts. This will allow some new ways to get to the settings faster like
a keyword search to go straight to the relevant setting which may prove
faster and easier for users. This search may mitigate the need for these
shortcuts.
…On Wed, Jul 5, 2017 at 6:50 AM, James Teh ***@***.***> wrote:
***@***.**** <https://github.com/leonardder> commented on 5 Jul 2017,
02:36 GMT+10
<#7302 (comment)>:
So this means speech dictionaries, input gestures, etc. should also go
into this dialog?
Blerg. No, I don't think that makes sense actually. If we were starting
from scratch, I'd probably have a Preferences menu containing a Settings...
item (this dialog) and the rest of the items as they are (Speech
dictionaries, etc.). The problem is that this definitely breaks those
well-known shortcuts.
I guess the only way to get around this is to somehow alter the way key
presses are handled in the NVDA menu. Yuck.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#7302 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ADVGElyFZdJBHJZUFT8mK-VDWbjrzrD3ks5sKsHJgaJpZM4N9_GL>
.
--
Regards,
Reef Turner
|
@feerrenrut commented on 5 Jul 2017, 14:33 GMT+10:
As discussed out-of-band, I meant to say "button" instead of "dialog" here... and we are indeed talking about the same thing. :) After some extremely lengthy discussion, here's what we think should happen.
Notes:
|
@jcsteh commented on 5 jul. 2017 07:51 CEST:
I assume you also considered renaming preferences to settings? This is probably something we should not do due to the same reasons as above? |
We didn't, actually, but as you say, I don't think we should do this for the same reasons. |
@feerrenrut, could you have another look? I hopefully improved stuff regarding the layout. |
what about addons breaking? Should we provide an AddPage method somehow to add a settings page for an addon? |
What about add-ons breaking? Why would they break?
|
@LeonarddeR I have had another look now. This seems to be coming along nicely.
|
@feerrenrut commented on 6 jul. 2017 04:52 CEST:
That shouldn't be that difficult to do, the only question is, how wide should the space be. I will try to come up with something.
Formally, this is not related to this issue, the problem with the current change is that this problem is getting more and more obvious. Would this really block the new dialog from a visual perspective? |
They would break because it is no longer a preferences submenu, and many add their item to the preferences submenu. |
@LeonarddeR I dont think #577 should be blocked by #6455. Fixing the issues in #6455 will improve the NVDA ux generally. But it isn't required for this work. I think you had it right saying:
The change to put the different settings pages in one dialog highlights the difference in width of the items within those dialogs. |
@feerrenrut: I now added the requested vertical line, checked with object nav and it seems to be as high as the panel, which is what I intended. I also changed the width of the tree view a bit, based on the current items in it, it shouldn't be wider than 100, but correct me if I'm wrong. This should also mean that the panel is more left now. I also wonder whether it would be possible to get rid of the scrollbar(s) for the tree view, but it seems changing the height doesn't make that much difference. |
@derekriemer commented on 6 jul. 2017 07:07 CEST:
You probably missed #7302 (comment) |
gotcha. What about providing a way for addons to register a dialog or page with the new dialog? Did I miss that too? sorry, we had a holiday here, and I missed some tickets because I decided to stop using email for github and use notifications instead. |
@derekriemer commented on 6 jul. 2017 11:26 CEST:
At the moment, registering a new panel is as easy as creating a Settingspanel AND DOING GUI.settingsDialogs.NVDASettingsDialog.categoryClasses.append(newClass) |
removed a comma from the title. |
I cleaned this up a bit and squashed this back into three commits now, but before this is ready for review, there's some work to be done, might do another squash later. Note that this is not the normal procedure for pull requests, since normally they are opened when they are ready for review. @feerrenrut: I got some assistance from my wife and I got rid of the scrollbars now. My wife commented that it looks a bit strange to have nothing in the left bottom corner of the dialog. Would it be nice to vertically center align the tree view? I also added control+tab and control+shift+tab support for easier navigation between tabs. This is currently a way to go back to the categories list. I'm a bit hesitant with adding an accelerator to the tree view. Since we have the char_hook on the dialog anyway, I'd rather make F6 switch between the panel and the tree view. @derekriemer commented on 7 jul. 2017 00:35 CEST:
Oops, that was me applying dutch rules to English text. |
@feerrenrut: Coming back to this, I think this is ready for review already, unless we really want an accelerator for the tree view. However, layout review is something that can be done as part of the code review. |
…r settings. This fixes #577. The following is changed: 1. Added new classes: * MultiCategorySettingsDialog * NVDASettingsDialog * SettingsPanel 2. Changed several settings dialogs to be settings panels, and included them in the new NVDASettingsDialog 3. Added an apply button to the new dialog, and added the possibility to add these to other settings dialogs as well 4. Added control+tab and control+shift+tab keyboard commands to switch between the various settings categories 5. Added the possibility to easily override the orientation of the settings sizer in settings dialogs, since the settings sizer needs to be horizontal in a multi category dialog 6. Changed several doc strings and translator comments to reflect the new situation 7. Updated gui/__init__.py to reflect the new situation
… unintentional double space in this file
hi.
i've found one bug.
in synthesizer selection screen, output device is not changing without
restarting nvda.
…On 4/9/18, netblue44 ***@***.***> wrote:
Further more we already have insert plus control plus S to Change
synthesizer
On 07/04/2018 01:33 p. m., Michael Curran wrote:
> If we do change the default focused control on the speech page to the
> voice combo box, then I feel this will cause many users to never find
> the Change Synthesizer button. If we do decide to do this, then we
> should move the Change synthesizer button to further in the tab order.
> But personally... I think users can just get used to pressing tab one
> more time to get to the Voice combo box in the first place.
>
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <#7302 (comment)>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/API6edqfoyXHIrhl9rdnq13YI2wKuqZjks5tmRSYgaJpZM4N9_GL>.
>
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
#7302 (comment)
--
with best regards beqa
|
Thanks for catching that one. However, this bug also exists in master,
so isn't a regression caused by this new dialog. There doesn't seem to
be a separate issue for this though. I'll see what I can do about this
within the scope of this pr.
|
i didn't notice it before.
…On 4/9/18, Leonard de Ruijter ***@***.***> wrote:
Thanks for catching that one. However, this bug also exists in master,
so isn't a regression caused by this new dialog. There doesn't seem to
be a separate issue for this though. I'll see what I can do about this
within the scope of this pr.
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
#7302 (comment)
--
with best regards beqa
|
…dialog, just as we did before
@leonardder commented on 9 apr. 2018 16:31 CEST:
I horribly lied there. Just pushed a commit that fixes this and restores the old behaviour. I have no idea why this has been changed, actually. Probably in order not to reload a currently active synthesizer when it's already active. |
@michaelDCurran commented on 7 apr. 2018 21:33 CEST:
When pressing ctrl+NVDA+v, it is two tabs to the voice combo box, or pressing alt+v. People who would like to change voices more quickly really should consider using the synthesizer settings ring. Moving the change synthesizer button further in the tab order will create an asymmetry with the braille settings dialog. In there, the braille display selection combo box has always been the first option. |
For these reasons I really feel we should not make any change here.
|
This is then used to set initial sizes in the dialogs.
Fixed issues related to scaling on high DPI systems
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've had a look over the rest of these changes, it looks good to me. @michaelDCurran if you are also happy, can we re-incubate this?
Based on Master 15089,482e916c: Why is the menu entry "Settings..." in the NVDA menu called "Settings..." and not "NVDA Settings..."? In the manual the new dialog is called "11.1. NVDA Settings". |
Hi, most likely because the entry in the menu is already part of NVDA menu, thus no need to repeat that. Thanks.
From: Daniel Mayr <notifications@github.com>
Sent: Sunday, May 6, 2018 6:54 AM
To: nvaccess/nvda <nvda@noreply.github.com>
Cc: Joseph Lee <joseph.lee22590@gmail.com>; Mention <mention@noreply.github.com>
Subject: Re: [nvaccess/nvda] Change multiple settings dialogs into one category based dialog (#7302)
Based on Master 15089,482e916c: Why is the menu entry "Settings..." in the NVDA menu called "Settings..." and not "NVDA Settings..."? In the manual the new dialog is called "11.1. NVDA Settings".
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#7302 (comment)> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AHgLkDnOrwqCgE4a3dnDXsnJbNNrCTeFks5tvwB4gaJpZM4N9_GL> .
|
EN path: NVDA menu -> Preferences -> Settings... The words "preferences" and "settings" mean the same in German – Einstellungen. And as the manual call it "NVDA Settings", translating this in other languages might cause less irritations. New EN path: NVDA menu -> &Preferences -> NVDA &Settings... |
Since there is less ambiguity (or at least there is more than one word) in English, and brevity is desirable, I would suggest keeping the English as is. Happy for the German translation to be changed if it makes it clearer. Perhaps we can update the |
In Dutch, for all the English words that can be used for settings, we
have a one to one translation:
* preferences > voorkeuren
* Settings > instellingen
* Options > Opties
Somehow, preferences got translated to opties in the early days, and I'd
choose to keep it that way. In German, it looks a bit more complex
indeed. May be you could do something with the word Optionen here?
|
The words "Voreinstellungen" and "Optionen" would be possible but the first one sounds a little bit strange here. Well, and the second one change the whole wording - and the manual has to change to the new wording too. So the final question is: Have the translators the permission to add the prefix "NVDA" (or "NVDA-") for the "Settings..." menu entry if it is necessary in their languages? On German - as well as in English - most of the people will say "Öffne die NVDA-Einstellungen und gehe dort zu ..." (EN: "Open the NVDA settings and go to ..."). In the end some languages have the NVDA-prefix here and some not. Would this a suitable solution for you? And as long as Add-on can enter menu items anywhere in the NVDA menu, adding the NVDA-prefix could reduce irritations as well. But I also understand that the NVDA-prefix isn't necessary in all languages at all. |
Hi, ultimately, it should be decided by the language community, as you can translate it anyway you want in the .po file. Thanks.
From: Daniel Mayr <notifications@github.com>
Sent: Monday, May 7, 2018 7:54 AM
To: nvaccess/nvda <nvda@noreply.github.com>
Cc: Joseph Lee <joseph.lee22590@gmail.com>; Mention <mention@noreply.github.com>
Subject: Re: [nvaccess/nvda] Change multiple settings dialogs into one category based dialog (#7302)
The words "Voreinstellungen" and "Optionen" would be possible but the first one sounds a little bit strange here. Well, and the second one change the whole wording - and the manual has to change to the new wording too.
So the final question is: Have the translators the permission to add the prefix "NVDA" (or "NVDA-") for the "Settings..." menu entry if it is necessary in their languages? On German - as well as in English - most of the people will say "Öffne die NVDA-Einstellungen und gehe dort zu ..." (EN: "Open the NVDA settings and go to ..."). In the end some languages have the NVDA-prefix here and some not. Would this a suitable solution for you? And as long as Add-on can enter menu items anywhere in the NVDA menu, adding the NVDA-prefix could reduce irritations as well. But I also understand that the NVDA-prefix isn't necessary in all languages at all.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#7302 (comment)> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AHgLkFfsGWEOTjaoAQRJXaGCDuuEZ6Hsks5twGAjgaJpZM4N9_GL> .
|
Link to issue number:
closes #5774
closes #3644
Closes #4040
Summary of the issue:
Based on #577 (comment)
In the current situation, several settings subjects have their own dialog in NVDA. This makes configuring NVDA more complicated than necessary (i.e. you can't update all settings in one go and need to open multiple dialogs, either using the menu or using shortcut keys).
Description of how this pull request fixes the issue:
This pr combines the several configuration manager based dialogs into one single dialog. The resulting dialog has a list view with categories on the left side and a panel containing the settings on the right side.
Known issues with pull request:
From #577 (comment)
Todo