UIA: Reporting landmark shouldn't rely on localized landmark property

[LeonarddeR]

In Edge, NVDA relies on UIAHandler.UIA_LocalizedLandmarkTypePropertyId to retrieve landmark information. In Dutch, landmark translations are fairly poor. For example, main translates to vast, which back translates to fixed (as in fixed size). Reporting landmarks in Dutch breaks anyway.

There is also UIAHandler.UIA_LandmarkTypePropertyId. We might be able to use that instead?

[josephsl]

Hi, is Microsoft aware of this? Thanks. From: Leonard de Ruijter [mailto:notifications@github.com] Sent: Tuesday, June 27, 2017 9:15 AM To: nvaccess/nvda <nvda@noreply.github.com> Cc: Subscribed <subscribed@noreply.github.com> Subject: [nvaccess/nvda] UIA: Reporting landmark shouldn't rely on localized landmark property (#7328) In Edge, NVDA relies on UIAHandler.UIA_LocalizedLandmarkTypePropertyId to retrieve landmark information. In Dutch, landmark translations are fairly poor. For example, main translates to vast, which back translates to fixed (as in fixed size). Reporting landmarks in Dutch breaks anyway. There is also UIAHandler.UIA_LandmarkTypePropertyId. We might be able to use that instead? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#7328> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AHgLkLwbOCK5cKbkavVDrzY4XgCfpe7aks5sISpngaJpZM4OG3Jw> .

[jcsteh]

@michaelDCurran, any particular reason we use the localized property here? I'd argue it makes sense to be consistent with the landmark names used in other browsers (as specified in our aria module).

[michaelDCurran]

landMarkType only has a hand full of constants. I guess we should at least support the constants it does have. but from memory some pretty important ones are missing currently. If role is exposed via ariaProperties then we could also just use that.

[derekriemer]

But "main" isn't a role, or is it?

…

On Tue, Jun 27, 2017 at 8:55 PM, Michael Curran ***@***.***> wrote: landMarkType only has a hand full of constants. I guess we should at least support the constants it does have. but from memory some pretty important ones are missing currently. If role is exposed via ariaProperties then we could also just use that. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#7328 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFGivRYFRUfvVP5KjOMA-Q4EsMEtio8mks5sIcC0gaJpZM4OG3Jw> .

-- Derek Riemer: Improving the world one byte at a time! - University of Colorado Boulder Department of computer science, 4th year undergraduate student. - Accessibility enthusiast. - Proud user of the NVDA screen reader. - Open source enthusiast. - Skier. Personal website <http://derekriemer.com>

[LeonarddeR]

landMarkType only has a hand full of constants. I guess we should at least support the constants it does have. but from memory some pretty important ones are missing currently.

Banner, complementary and contentinfo are missing.

[LeonarddeR]

If role is exposed via ariaProperties then we could also just use that.

It is. So we can just go the role way using aria properties, or use the excisting landmark constants and fallback to role for the landmarks which don't have a constant. Personally, I prefer the first approach.

[jcsteh]

So does LocalizedLandmark still work for the missing landmarks? And if so, what does (non-localized) Landmark return in that case? Note that we should still probably use LocalizedLandmark for quick nav, since there can be multiple ARIA roles and I don't think there's a way to do a token match with UIA conditions.

[LeonarddeR]

So does LocalizedLandmark still work for the missing landmarks?

Yes

And if so, what does (non-localized) Landmark return in that case?

The number 80000, UIA_CustomLandmarkTypeId

Note that we should still probably use LocalizedLandmark for quick nav, since there can be multiple ARIA roles and I don't think there's a way to do a token match with UIA conditions.

Sounds like we are on one line here.

[LeonarddeR]

Note that we should still probably use LocalizedLandmark for quick nav.

Coming back to this, it turns out that we can use the unlocalized Landmark property without problems, since it is not 0 for landmarks.