New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIA: Reporting landmark shouldn't rely on localized landmark property #7328

Closed
leonardder opened this Issue Jun 27, 2017 · 9 comments

Comments

Projects
None yet
6 participants
@leonardder
Collaborator

leonardder commented Jun 27, 2017

In Edge, NVDA relies on UIAHandler.UIA_LocalizedLandmarkTypePropertyId to retrieve landmark information. In Dutch, landmark translations are fairly poor. For example, main translates to vast, which back translates to fixed (as in fixed size). Reporting landmarks in Dutch breaks anyway.

There is also UIAHandler.UIA_LandmarkTypePropertyId. We might be able to use that instead?

@josephsl

This comment has been minimized.

Show comment
Hide comment
@josephsl

josephsl Jun 27, 2017

Collaborator
Collaborator

josephsl commented Jun 27, 2017

@jcsteh

This comment has been minimized.

Show comment
Hide comment
@jcsteh

jcsteh Jun 28, 2017

Contributor
Contributor

jcsteh commented Jun 28, 2017

@michaelDCurran

This comment has been minimized.

Show comment
Hide comment
@michaelDCurran

michaelDCurran Jun 28, 2017

Contributor

landMarkType only has a hand full of constants. I guess we should at least support the constants it does have. but from memory some pretty important ones are missing currently. If role is exposed via ariaProperties then we could also just use that.

Contributor

michaelDCurran commented Jun 28, 2017

landMarkType only has a hand full of constants. I guess we should at least support the constants it does have. but from memory some pretty important ones are missing currently. If role is exposed via ariaProperties then we could also just use that.

@derekriemer

This comment has been minimized.

Show comment
Hide comment
@derekriemer

derekriemer Jun 28, 2017

Collaborator
Collaborator

derekriemer commented Jun 28, 2017

@leonardder

This comment has been minimized.

Show comment
Hide comment
@leonardder

leonardder Jun 28, 2017

Collaborator

landMarkType only has a hand full of constants. I guess we should at least support the constants it does have. but from memory some pretty important ones are missing currently.

Banner, complementary and contentinfo are missing.

Collaborator

leonardder commented Jun 28, 2017

landMarkType only has a hand full of constants. I guess we should at least support the constants it does have. but from memory some pretty important ones are missing currently.

Banner, complementary and contentinfo are missing.

@leonardder

This comment has been minimized.

Show comment
Hide comment
@leonardder

leonardder Jun 28, 2017

Collaborator

If role is exposed via ariaProperties then we could also just use that.

It is. So we can just go the role way using aria properties, or use the excisting landmark constants and fallback to role for the landmarks which don't have a constant. Personally, I prefer the first approach.

Collaborator

leonardder commented Jun 28, 2017

If role is exposed via ariaProperties then we could also just use that.

It is. So we can just go the role way using aria properties, or use the excisting landmark constants and fallback to role for the landmarks which don't have a constant. Personally, I prefer the first approach.

@jcsteh

This comment has been minimized.

Show comment
Hide comment
@jcsteh

jcsteh Jun 28, 2017

Contributor
Contributor

jcsteh commented Jun 28, 2017

@leonardder

This comment has been minimized.

Show comment
Hide comment
@leonardder

leonardder Jun 28, 2017

Collaborator

So does LocalizedLandmark still work for the missing landmarks?

Yes

And if so, what does (non-localized) Landmark return in that case?

The number 80000, UIA_CustomLandmarkTypeId

Note that we should still probably use LocalizedLandmark for quick nav, since there can be multiple ARIA roles and I don't think there's a way to do a token match with UIA conditions.

Sounds like we are on one line here.

Collaborator

leonardder commented Jun 28, 2017

So does LocalizedLandmark still work for the missing landmarks?

Yes

And if so, what does (non-localized) Landmark return in that case?

The number 80000, UIA_CustomLandmarkTypeId

Note that we should still probably use LocalizedLandmark for quick nav, since there can be multiple ARIA roles and I don't think there's a way to do a token match with UIA conditions.

Sounds like we are on one line here.

@leonardder

This comment has been minimized.

Show comment
Hide comment
@leonardder

leonardder Jun 28, 2017

Collaborator

Note that we should still probably use LocalizedLandmark for quick nav.

Coming back to this, it turns out that we can use the unlocalized Landmark property without problems, since it is not 0 for landmarks.

Collaborator

leonardder commented Jun 28, 2017

Note that we should still probably use LocalizedLandmark for quick nav.

Coming back to this, it turns out that we can use the unlocalized Landmark property without problems, since it is not 0 for landmarks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment