Use Python launcher if present #7541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was having some problems because I have two Python interpreters installed. So I changed the script to use the launcher. Cheers,
|
Hi, somewhat of an important blocker for #7105. Thanks.
From: Francisco R. Del Roio [mailto:notifications@github.com]
Sent: Tuesday, August 29, 2017 8:37 PM
To: nvaccess/nvda <nvda@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Subject: [nvaccess/nvda] Use Python launcher if present (#7541)
I was having some problems because I have two Python interpreters installed.
Sometimes various interpreters registered to run python scripts can cause problems when running in Windows 10, mainly if you have Python3 installed alongside with python2.
This is a quick workaround to fix this thing.
I've tested it and it works well.
Cheers,
…_____
You can view, comment on, or merge this pull request online at:
#7541
Commit Summary
* Use Python launcher if present
File Changes
* M scons.bat <https://github.com/nvaccess/nvda/pull/7541/files#diff-0> (12)
Patch Links:
* https://github.com/nvaccess/nvda/pull/7541.patch
* https://github.com/nvaccess/nvda/pull/7541.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub <#7541> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AHgLkG9d0NPfQ12VS9y9P64hnBIm7XFZks5sdNjJgaJpZM4PG01p> .
|
|
Hello, I know, but I think that this is a trivial change to do later when migration happens. Cheers, |
josephsl
approved these changes
Sep 29, 2017
|
Hi, @michaelDCurran, any comments? I think this could be useful for our eventual Python 3 transition (#7105). Thanks. |
|
On my Windows 10 machine build 16291 scons.bat always tries to call 'py' which on my system does not exist. It is as if where py succeeds with an errorlevel of 0. However, manually running it and echoing errorlevel its 1, not 0. Is the syntax of the if check correct? |
|
Hello, I've fixed it. Cheers, |
|
This is better. Can we also redirect stderr to nul as well? As if where does not locate the executable, an annoying info message is shown. Thanks |
…ure because of unexpected behavior when interrupting a command or when it exits with errors
michaelDCurran
approved these changes
Feb 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was having some problems because I have two Python interpreters installed.
Sometimes various interpreters registered to run python scripts can cause problems when running in Windows 10, mainly if you have Python3 installed alongside with python2.
This is a quick workaround to fix this thing.
I've tested it and it works well.
Cheers,