New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In latest next builds, trying to update next, then makes browser events die until reboot. #7641

Closed
derekriemer opened this Issue Oct 3, 2017 · 4 comments

Comments

Projects
None yet
6 participants
@derekriemer
Collaborator

derekriemer commented Oct 3, 2017

Background:

There's been a bug in NVDA for years that when we load source copies of NVDA, events in browsers fail to talk to us. Somehow, I always ignored this in source, because core developers experienced it too, however, with the introduction of #7563 I believe this got much worse. Every time I update next, NVDA stops responding to dynamic events until I reboot. I can still nvda+f5 to refresh however.

Hypothesis

Since the library version is changing every time our version updates, somehow, the old code is receiving events and the new code isn't. There's something I think with this, because if I change from binary to source, and back to binary under proper working conditions, the path used to be the same, and the code would work just fine. I propose introducing a try build of NVDA that beeps upon every event responded to in a vbuff. That way, I can run that version installed, reboot, install next, then try to see if I get beeps, suggesting the old code is running.

Steps to reproduce:

Under any earlier than latest <next|master|you choose> build of NVDA

  1. visit google.com.

  2. type chickens into the search box.

  3. now, go to the search box again, and type "horses"

    Expected: you can press 2 to find search results for horses.
    Actual: this works.

  4. Now, repeat steps 1-3 again, after updating NVDA (So long as you have a binary version you are fine). Update to either latest next or master.
    Expected: You get search results for Horses.
    Actual: You get search results for Chickens, if you get search results for anything.

  5. Now, press NVDA+f5.
    Note how you now have search results for horses.

System configuration:

NVDA version: anything post #7563

NVDA Installed or portable: Needs to be a binary build, other than that it doesn't matter.

Does the issue still occur after restarting your PC? No

Have you tried any other versions of NVDA? I've tried source, and the several next builds.

@dan1982code

This comment has been minimized.

dan1982code commented Oct 3, 2017

I can confirm this, but closing Firefox completely is enough to fix it for me (reboot not required).

@Brian1Gaff

This comment has been minimized.

Brian1Gaff commented Oct 3, 2017

@Brian1Gaff

This comment has been minimized.

Brian1Gaff commented Oct 3, 2017

@gregjozk

This comment has been minimized.

gregjozk commented Oct 4, 2017

confirmed. also see #7640. and as @dan1982code said restart of firefox solves a problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment